tools: Fixes in customtabs_benchmark.

tools: Small fixes in customtabs_benchmark.

- Fix metrics recording: delay incorrectly set, and simplify the logic
- Fix metrics parsing
- Output to a CSV file in prefetch_benchmark.

BUG=655980
Committed: https://crrev.com/b182f0b53f831f124539bb8f6f4696e48c55bcc0
Cr-Commit-Position: refs/heads/master@{#436300}

[Benoit L, 2016-12-05 15:15:21]

Description was changed from

==========
tools: Fixes in customtabs_benchmark.

- Fix metrics recording
- Fix metrics parsing
- Output to a CSV file in prefetch_benchmark.

BUG=655980
==========

to

==========
tools: Small fixes in customtabs_benchmark.

- Fix metrics recording: delay incorrectly set, and simplify the logic
- Fix metrics parsing
- Output to a CSV file in prefetch_benchmark.

BUG=655980
==========

[Benoit L, 2016-12-05 15:15:33]

lizeb@chromium.org changed reviewers:
+ droger@chromium.org

[Benoit L, 2016-12-05 15:15:38]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 15:15:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 15:27:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 15:27:13]

Dry run: This issue passed the CQ dry run.

[droger, 2016-12-05 15:35:09]

lgtm

https://codereview.chromium.org/2551913002/diff/1/tools/android/customtabs_be...
File
tools/android/customtabs_benchmark/java/src/org/chromium/customtabs/test/MainActivity.java
(left):

https://codereview.chromium.org/2551913002/diff/1/tools/android/customtabs_be...
tools/android/customtabs_benchmark/java/src/org/chromium/customtabs/test/MainActivity.java:116:
logMetricsAndFinishDelayed(3000);
Are you sure this was not useful?

The scenario I can think of is for a page that does not report the first
contentful paint.

With this call to logMetricsAndFinishDelayed, the test returns somewhat early (3
seconds after the load is complete).

With your change, I expect the full timeout to happen (like 20 seconds).

Maybe this happens rarely enough that we don't care.

[Benoit L, 2016-12-05 15:46:41]

Thanks!

https://codereview.chromium.org/2551913002/diff/1/tools/android/customtabs_be...
File
tools/android/customtabs_benchmark/java/src/org/chromium/customtabs/test/MainActivity.java
(left):

https://codereview.chromium.org/2551913002/diff/1/tools/android/customtabs_be...
tools/android/customtabs_benchmark/java/src/org/chromium/customtabs/test/MainActivity.java:116:
logMetricsAndFinishDelayed(3000);
On 2016/12/05 15:35:08, droger wrote:
> Are you sure this was not useful?
> 
> The scenario I can think of is for a page that does not report the first
> contentful paint.
> 
> With this call to logMetricsAndFinishDelayed, the test returns somewhat early
(3
> seconds after the load is complete).
> 
> With your change, I expect the full timeout to happen (like 20 seconds).
> 
> Maybe this happens rarely enough that we don't care.

Yes, this doesn't happen very often, and the code is simpler this way.
Acknowkledged.

[Benoit L, 2016-12-05 15:46:57]

The CQ bit was checked by lizeb@chromium.org

[commit-bot: I haz the power, 2016-12-05 15:47:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 15:52:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480952817877430, "parent_rev":
"2d5c180c98c7a24d02f298157e91a9c806b6cb4e", "commit_rev":
"8a3b9e90652db5db50408122c3012027569d8beb"}

[commit-bot: I haz the power, 2016-12-05 15:52:57]

Description was changed from

==========
tools: Small fixes in customtabs_benchmark.

- Fix metrics recording: delay incorrectly set, and simplify the logic
- Fix metrics parsing
- Output to a CSV file in prefetch_benchmark.

BUG=655980
==========

to

==========
tools: Small fixes in customtabs_benchmark.

- Fix metrics recording: delay incorrectly set, and simplify the logic
- Fix metrics parsing
- Output to a CSV file in prefetch_benchmark.

BUG=655980
==========

[commit-bot: I haz the power, 2016-12-05 15:52:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-05 15:55:51]

Description was changed from

==========
tools: Small fixes in customtabs_benchmark.

- Fix metrics recording: delay incorrectly set, and simplify the logic
- Fix metrics parsing
- Output to a CSV file in prefetch_benchmark.

BUG=655980
==========

to

==========
tools: Small fixes in customtabs_benchmark.

- Fix metrics recording: delay incorrectly set, and simplify the logic
- Fix metrics parsing
- Output to a CSV file in prefetch_benchmark.

BUG=655980

Committed: https://crrev.com/b182f0b53f831f124539bb8f6f4696e48c55bcc0
Cr-Commit-Position: refs/heads/master@{#436300}
==========

[commit-bot: I haz the power, 2016-12-05 15:55:52]

Patchset 1 (id:??) landed as
https://crrev.com/b182f0b53f831f124539bb8f6f4696e48c55bcc0
Cr-Commit-Position: refs/heads/master@{#436300}