Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 25519004: Use Skia API on Windows to get font family name (Closed)

Created:
7 years, 2 months ago by eae
Modified:
7 years, 2 months ago
Reviewers:
pdr., eseidel
CC:
blink-reviews
Visibility:
Public.

Description

Use Skia API on Windows to get font family name Change the Windows implementation of FontPlatformData::fontFamilyName to use the SkTypeface getFamilyName API instead of calling GDI directly. This further reduces our reliance on HFONTs and gets us closer to removing the HFONT reference entirely. BUG=251355 R=pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160284

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eae
7 years, 2 months ago (2013-10-22 23:37:26 UTC) #1
eseidel
lgtm
7 years, 2 months ago (2013-10-22 23:41:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/25519004/2001
7 years, 2 months ago (2013-10-22 23:41:46 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-23 01:51:31 UTC) #4
Message was sent while issue was closed.
Change committed as 160284

Powered by Google App Engine
This is Rietveld 408576698