Adding ASSERT for RuntimeEnabled feature XSLT

Adding ASSERT for RuntimeEnabled feature XSLT

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158759

[vivekg__, 2013-10-01 13:07:47]

Adding the ASSERTS as we discussed over IRC, please take a look, thanks!

[abarth-chromium, 2013-10-01 15:06:08]

LGTM with some comments below

https://codereview.chromium.org/25519002/diff/1/Source/core/fetch/ResourceFet...
File Source/core/fetch/ResourceFetcher.cpp (right):

https://codereview.chromium.org/25519002/diff/1/Source/core/fetch/ResourceFet...
Source/core/fetch/ResourceFetcher.cpp:344:
ASSERT(RuntimeEnabledFeatures::xsltEnabled());
I'm not sure this ASSERT is worth messing up the code for.

https://codereview.chromium.org/25519002/diff/1/Source/core/fetch/ResourceFet...
Source/core/fetch/ResourceFetcher.cpp:423:
ASSERT(RuntimeEnabledFeatures::xsltEnabled());
You can do this with less duplicated code by putting XSLStyleSheet above
SVGDocument.  Then you can ASSERT and use the fall-through behavior to execute
the canRequest check.

https://codereview.chromium.org/25519002/diff/1/Source/core/fetch/ResourceFet...
Source/core/fetch/ResourceFetcher.cpp:641:
ASSERT(RuntimeEnabledFeatures::xsltEnabled());
Same here.

https://codereview.chromium.org/25519002/diff/1/Source/core/fetch/XSLStyleShe...
File Source/core/fetch/XSLStyleSheetResource.cpp (right):

https://codereview.chromium.org/25519002/diff/1/Source/core/fetch/XSLStyleShe...
Source/core/fetch/XSLStyleSheetResource.cpp:43:
ASSERT(RuntimeEnabledFeatures::xsltEnabled());
All these ASSERTs are super redundant.  This is the only one that matters for
the whole fetch directory.  Maybe remove the others and keep this one?

[vivekg__, 2013-10-02 14:18:23]

Thank you Adam for the review. Modified the patch accordingly , please take a
look.

https://codereview.chromium.org/25519002/diff/1/Source/core/fetch/ResourceFet...
File Source/core/fetch/ResourceFetcher.cpp (right):

https://codereview.chromium.org/25519002/diff/1/Source/core/fetch/ResourceFet...
Source/core/fetch/ResourceFetcher.cpp:344:
ASSERT(RuntimeEnabledFeatures::xsltEnabled());
On 2013/10/01 15:06:09, abarth wrote:
> I'm not sure this ASSERT is worth messing up the code for.

Done.

https://codereview.chromium.org/25519002/diff/1/Source/core/fetch/ResourceFet...
Source/core/fetch/ResourceFetcher.cpp:423:
ASSERT(RuntimeEnabledFeatures::xsltEnabled());
On 2013/10/01 15:06:09, abarth wrote:
> You can do this with less duplicated code by putting XSLStyleSheet above
> SVGDocument.  Then you can ASSERT and use the fall-through behavior to execute
> the canRequest check.

Done.

https://codereview.chromium.org/25519002/diff/1/Source/core/fetch/ResourceFet...
Source/core/fetch/ResourceFetcher.cpp:641:
ASSERT(RuntimeEnabledFeatures::xsltEnabled());
On 2013/10/01 15:06:09, abarth wrote:
> Same here.

Done.

https://codereview.chromium.org/25519002/diff/1/Source/core/fetch/XSLStyleShe...
File Source/core/fetch/XSLStyleSheetResource.cpp (right):

https://codereview.chromium.org/25519002/diff/1/Source/core/fetch/XSLStyleShe...
Source/core/fetch/XSLStyleSheetResource.cpp:43:
ASSERT(RuntimeEnabledFeatures::xsltEnabled());
On 2013/10/01 15:06:09, abarth wrote:
> All these ASSERTs are super redundant.  This is the only one that matters for
> the whole fetch directory.  Maybe remove the others and keep this one?

Done. Also removed one ASSERT check before the new XSLStyleSheetResource
creation in ResourceFetcher.cpp. Should we also remove all the other ASSERTs
which are there in ResourceFetcher.cpp?

[abarth-chromium, 2013-10-02 15:06:38]

lgtm

[commit-bot: I haz the power, 2013-10-02 15:06:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/25519002/6001

[commit-bot: I haz the power, 2013-10-02 16:16:27]

Retried try job too often on win_layout for step(s) webkit_lint
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-10-02 18:14:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/25519002/6001

[commit-bot: I haz the power, 2013-10-02 21:44:24]

Change committed as 158759