Embedding-CSP: Adding `const` to method signatures.

Embedding-CSP: Adding `const` to method signatures.

BUG=647588
Committed: https://crrev.com/9757fb4e3353e8844264b04ed7145bf457288ad7
Cr-Commit-Position: refs/heads/master@{#436558}

[amalika, 2016-12-05 08:45:20]

The CQ bit was checked by amalika@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 08:45:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[amalika, 2016-12-05 08:45:36]

amalika@google.com changed reviewers:
+ mkwst@chromium.org

[Mike West, 2016-12-05 09:06:59]

I like const! LGTM.

[commit-bot: I haz the power, 2016-12-05 10:09:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 10:09:13]

Dry run: This issue passed the CQ dry run.

[amalika, 2016-12-05 13:54:41]

The CQ bit was checked by amalika@google.com

[commit-bot: I haz the power, 2016-12-05 13:54:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 13:59:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 13:59:07]

Failed to apply patch for
third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp:593
  error: third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp: patch
does not apply

Patch:       third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp
Index: third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp
diff --git a/third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp
b/third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp
index
2f85ce3ebce121fe8463280416738918d98fe997..c00b6d3d7848475a58914f672cc22ae0c8b92fb9
100644
--- a/third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp
+++ b/third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp
@@ -579,7 +579,7 @@ bool SourceListDirective::hasSourceMatchInList(
   return false;
 }
 
-bool SourceListDirective::allowAllInline() {
+bool SourceListDirective::allowAllInline() const {
   const ContentSecurityPolicy::DirectiveType& type =
       ContentSecurityPolicy::getDirectiveType(m_directiveName);
   if (type != ContentSecurityPolicy::DirectiveType::DefaultSrc &&
@@ -593,7 +593,7 @@ bool SourceListDirective::allowAllInline() {
 }
 
 bool SourceListDirective::subsumes(
-    HeapVector<Member<SourceListDirective>> other) {
+    const HeapVector<Member<SourceListDirective>>& other) const {
   // TODO(amalika): Handle here special keywords.
   if (!m_list.size() || !other.size())
     return !m_list.size();
@@ -631,7 +631,7 @@ bool SourceListDirective::subsumes(
 }
 
 HashMap<String, CSPSource*> SourceListDirective::getIntersectSchemesOnly(
-    HeapVector<Member<CSPSource>> other) {
+    const HeapVector<Member<CSPSource>>& other) const {
   HashMap<String, CSPSource*> schemesA;
   for (const auto& sourceA : m_list) {
     if (sourceA->isSchemeOnly())
@@ -655,7 +655,7 @@ HashMap<String, CSPSource*>
SourceListDirective::getIntersectSchemesOnly(
 }
 
 HeapVector<Member<CSPSource>> SourceListDirective::getIntersectCSPSources(
-    HeapVector<Member<CSPSource>> other) {
+    const HeapVector<Member<CSPSource>>& other) const {
   HashMap<String, CSPSource*> schemesMap = getIntersectSchemesOnly(other);
   HeapVector<Member<CSPSource>> normalized;
   // Add all normalized scheme source expressions.

[amalika, 2016-12-05 14:25:40]

The CQ bit was checked by amalika@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 14:25:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 15:42:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 15:42:12]

Dry run: This issue passed the CQ dry run.

[amalika, 2016-12-06 06:58:36]

The CQ bit was checked by amalika@google.com

[amalika, 2016-12-06 06:58:37]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2551843002/#ps20001
(title: "Rebasing")

[commit-bot: I haz the power, 2016-12-06 06:58:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 07:05:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 07:05:17]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[amalika, 2016-12-06 07:19:51]

The CQ bit was checked by amalika@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 07:20:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[amalika, 2016-12-06 07:20:01]

The CQ bit was unchecked by amalika@google.com

[amalika, 2016-12-06 07:20:12]

The CQ bit was checked by amalika@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 07:20:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 07:27:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 07:27:10]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[amalika, 2016-12-06 07:46:26]

The CQ bit was checked by amalika@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 07:46:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 10:05:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 10:05:02]

Dry run: This issue passed the CQ dry run.

[amalika, 2016-12-06 10:07:43]

The CQ bit was checked by amalika@google.com

[amalika, 2016-12-06 10:07:44]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2551843002/#ps40001
(title: "Rebasing")

[commit-bot: I haz the power, 2016-12-06 10:08:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 10:13:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481018863708430,
"parent_rev": "ba581379ead20eb52872c717f9cefdd28abf2834", "commit_rev":
"074d1336770939b947c70e211f9c426be369e40f"}

[commit-bot: I haz the power, 2016-12-06 10:13:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-06 10:15:32]

Description was changed from

==========
Embedding-CSP: Adding `const` to method signatures.

BUG=647588
==========

to

==========
Embedding-CSP: Adding `const` to method signatures.

BUG=647588

Committed: https://crrev.com/9757fb4e3353e8844264b04ed7145bf457288ad7
Cr-Commit-Position: refs/heads/master@{#436558}
==========

[commit-bot: I haz the power, 2016-12-06 10:15:33]

Patchset 3 (id:??) landed as
https://crrev.com/9757fb4e3353e8844264b04ed7145bf457288ad7
Cr-Commit-Position: refs/heads/master@{#436558}