Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2551823002:
RemoteFontFaceSource should not call startLoadLimitTimers() if startLoad() fails (Closed)
|
Created:
4 years ago by Takashi Toyoshima Modified:
4 years ago CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemoteFontFaceSource should not call startLoadLimitTimers() if startLoad() fails
startLoad() can fail, and in such cases startLoadLimitTimers() should
not be called. Otherwise, DCHECK does not pass, and FontResource would
be confused.
BUG=670638
TEST=Tools/Scripts/run-webkit-tests http/tests/css css3/fonts fonts
Committed: https://crrev.com/3314d6738177bd8b6ad6a8741dd0b26411810a27
Cr-Commit-Position: refs/heads/master@{#436535}
Patch Set 1 #
Messages
Total messages: 18 (11 generated)
The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== RemoteFontFaceSource should not call startLoadLimitTimers() if startLoad() fails startLoad() can fail, and in such cases startLoadLimitTimers() should not be called. Otherwise, DCHECK does not pass, and FontResource would be confused. BUG=670638 ========== to ========== RemoteFontFaceSource should not call startLoadLimitTimers() if startLoad() fails startLoad() can fail, and in such cases startLoadLimitTimers() should not be called. Otherwise, DCHECK does not pass, and FontResource would be confused. BUG=670638 TEST=Tools/Scripts/run-webkit-tests http/tests/css css3/fonts fonts ==========
toyoshim@chromium.org changed reviewers: + yhirano@chromium.org
ptal
lgtm
toyoshim@chromium.org changed reviewers: + haraken@chromium.org
+haraken for OWNERS' approval
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by toyoshim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481001190044780, "parent_rev":
"97b85e52c45ad6f74c52687de4fc6945a7c1c4d0", "commit_rev":
"45a2d606098d7b5c672eeac9ef7df2f9298b4e05"}
Message was sent while issue was closed.
Description was changed from ========== RemoteFontFaceSource should not call startLoadLimitTimers() if startLoad() fails startLoad() can fail, and in such cases startLoadLimitTimers() should not be called. Otherwise, DCHECK does not pass, and FontResource would be confused. BUG=670638 TEST=Tools/Scripts/run-webkit-tests http/tests/css css3/fonts fonts ========== to ========== RemoteFontFaceSource should not call startLoadLimitTimers() if startLoad() fails startLoad() can fail, and in such cases startLoadLimitTimers() should not be called. Otherwise, DCHECK does not pass, and FontResource would be confused. BUG=670638 TEST=Tools/Scripts/run-webkit-tests http/tests/css css3/fonts fonts ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== RemoteFontFaceSource should not call startLoadLimitTimers() if startLoad() fails startLoad() can fail, and in such cases startLoadLimitTimers() should not be called. Otherwise, DCHECK does not pass, and FontResource would be confused. BUG=670638 TEST=Tools/Scripts/run-webkit-tests http/tests/css css3/fonts fonts ========== to ========== RemoteFontFaceSource should not call startLoadLimitTimers() if startLoad() fails startLoad() can fail, and in such cases startLoadLimitTimers() should not be called. Otherwise, DCHECK does not pass, and FontResource would be confused. BUG=670638 TEST=Tools/Scripts/run-webkit-tests http/tests/css css3/fonts fonts Committed: https://crrev.com/3314d6738177bd8b6ad6a8741dd0b26411810a27 Cr-Commit-Position: refs/heads/master@{#436535} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3314d6738177bd8b6ad6a8741dd0b26411810a27 Cr-Commit-Position: refs/heads/master@{#436535} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
