Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: src/objects-inl.h

Issue 2551763003: v8::Private::ForApi should be context-independent. (Closed)
Patch Set: fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.h ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 3683 matching lines...) Expand 10 before | Expand all | Expand 10 after
3694 } 3694 }
3695 return String::SlowEquals(Handle<String>::cast(one), 3695 return String::SlowEquals(Handle<String>::cast(one),
3696 Handle<String>::cast(two)); 3696 Handle<String>::cast(two));
3697 } 3697 }
3698 3698
3699 3699
3700 ACCESSORS(Symbol, name, Object, kNameOffset) 3700 ACCESSORS(Symbol, name, Object, kNameOffset)
3701 SMI_ACCESSORS(Symbol, flags, kFlagsOffset) 3701 SMI_ACCESSORS(Symbol, flags, kFlagsOffset)
3702 BOOL_ACCESSORS(Symbol, flags, is_private, kPrivateBit) 3702 BOOL_ACCESSORS(Symbol, flags, is_private, kPrivateBit)
3703 BOOL_ACCESSORS(Symbol, flags, is_well_known_symbol, kWellKnownSymbolBit) 3703 BOOL_ACCESSORS(Symbol, flags, is_well_known_symbol, kWellKnownSymbolBit)
3704 3704 BOOL_ACCESSORS(Symbol, flags, is_public, kPublicBit)
3705 3705
3706 bool String::Equals(String* other) { 3706 bool String::Equals(String* other) {
3707 if (other == this) return true; 3707 if (other == this) return true;
3708 if (this->IsInternalizedString() && other->IsInternalizedString()) { 3708 if (this->IsInternalizedString() && other->IsInternalizedString()) {
3709 return false; 3709 return false;
3710 } 3710 }
3711 return SlowEquals(other); 3711 return SlowEquals(other);
3712 } 3712 }
3713 3713
3714 3714
(...skipping 4753 matching lines...) Expand 10 before | Expand all | Expand 10 after
8468 #undef WRITE_INT64_FIELD 8468 #undef WRITE_INT64_FIELD
8469 #undef READ_BYTE_FIELD 8469 #undef READ_BYTE_FIELD
8470 #undef WRITE_BYTE_FIELD 8470 #undef WRITE_BYTE_FIELD
8471 #undef NOBARRIER_READ_BYTE_FIELD 8471 #undef NOBARRIER_READ_BYTE_FIELD
8472 #undef NOBARRIER_WRITE_BYTE_FIELD 8472 #undef NOBARRIER_WRITE_BYTE_FIELD
8473 8473
8474 } // namespace internal 8474 } // namespace internal
8475 } // namespace v8 8475 } // namespace v8
8476 8476
8477 #endif // V8_OBJECTS_INL_H_ 8477 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698