v8::Private::ForApi should be context-independent.

v8::Private::ForApi should be context-independent.

This is done by reimplementing Symbol.for directly on top of
NameDictionary. A nice side effect is the removal of src/js/symbol.js

R=jochen@chromium.org, peria@chromium.org
BUG=chromium:617892
Committed: https://crrev.com/d26cdb7d6f0b327c15cdb866dafbc21c29a65d4d
Cr-Commit-Position: refs/heads/master@{#41520}

[jochen (gone - plz use gerrit), 2016-12-05 13:37:36]

lgtm

I wonder whether the builtins should be TF stubs? not sure how often we need
symbols

[Yang, 2016-12-05 13:45:18]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 13:45:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2016-12-05 13:49:37]

On 2016/12/05 13:37:36, jochen wrote:
> lgtm
> 
> I wonder whether the builtins should be TF stubs? not sure how often we need
> symbols

I don't think so. These builtins are only used to create/get canonical symbols.
That should not be hot code.

[commit-bot: I haz the power, 2016-12-05 13:51:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 13:51:38]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[jochen (gone - plz use gerrit), 2016-12-05 15:21:44]

ok, lgtm stands

[peria, 2016-12-06 05:12:36]

Thank you for this work!
LGTM

you can commit it ignoring my comments on files.

https://codereview.chromium.org/2551763003/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/2551763003/diff/1/src/heap/heap.h#newcode202
src/heap/heap.h:202: V(NameDictionary, public_symbol_table, PublicSymbolTable)  
                 \
optional;
I don't know the ordering rule, but isn't it better to
move these new macros in between #194-195?
We have another V(NameDictionary, ...) on #194.

https://codereview.chromium.org/2551763003/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2551763003/diff/1/src/objects.h#newcode9677
src/objects.h:9677: static const int kIsPublicBit = 2;
inconsistent with "kPrivateBit"

[Yang, 2016-12-06 10:43:13]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-12-06 10:43:13]

The patchset sent to the CQ was uploaded after l-g-t-m from peria@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2551763003/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2016-12-06 10:43:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 10:50:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 10:50:15]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Yang, 2016-12-06 12:53:07]

https://codereview.chromium.org/2551763003/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/2551763003/diff/1/src/heap/heap.h#newcode202
src/heap/heap.h:202: V(NameDictionary, public_symbol_table, PublicSymbolTable)  
                 \
On 2016/12/06 05:12:36, peria wrote:
> optional;
> I don't know the ordering rule, but isn't it better to
> move these new macros in between #194-195?
> We have another V(NameDictionary, ...) on #194.

Done.

https://codereview.chromium.org/2551763003/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2551763003/diff/1/src/objects.h#newcode9677
src/objects.h:9677: static const int kIsPublicBit = 2;
On 2016/12/06 05:12:36, peria wrote:
> inconsistent with "kPrivateBit"

Done.

[Yang, 2016-12-06 12:53:11]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-12-06 12:53:11]

The patchset sent to the CQ was uploaded after l-g-t-m from peria@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2551763003/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2016-12-06 12:53:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 13:21:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481028791142040,
"parent_rev": "8e43bf214eb1c527994a1cb8cb72cb785e1e98f3", "commit_rev":
"60bf0eab43a47171799ccc33a46744170f093309"}

[commit-bot: I haz the power, 2016-12-06 13:21:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-06 13:21:48]

Description was changed from

==========
v8::Private::ForApi should be context-independent.

This is done by reimplementing Symbol.for directly on top of
NameDictionary. A nice side effect is the removal of src/js/symbol.js


R=jochen@chromium.org, peria@chromium.org
BUG=chromium:617892
==========

to

==========
v8::Private::ForApi should be context-independent.

This is done by reimplementing Symbol.for directly on top of
NameDictionary. A nice side effect is the removal of src/js/symbol.js

R=jochen@chromium.org, peria@chromium.org
BUG=chromium:617892

Committed: https://crrev.com/d26cdb7d6f0b327c15cdb866dafbc21c29a65d4d
Cr-Commit-Position: refs/heads/master@{#41520}
==========

[commit-bot: I haz the power, 2016-12-06 13:21:49]

Patchset 3 (id:??) landed as
https://crrev.com/d26cdb7d6f0b327c15cdb866dafbc21c29a65d4d
Cr-Commit-Position: refs/heads/master@{#41520}