Issue 2551713002: dart2js-kernel: Implement JS_CALL_IN_ISOLATE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2551713002: dart2js-kernel: Implement JS_CALL_IN_ISOLATE (Closed)

Created:
4 years ago by sra1

Modified:
4 years ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js-kernel: Implement JS_CALL_IN_ISOLATE R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/7207dcd3768fd8e6631d63b3a93573390766f9f4

Patch Set 1 #

Total comments: 1

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -9 lines)			Patch
	M	pkg/compiler/lib/src/ssa/builder_kernel.dart	View		2 chunks	+21 lines, -9 lines	1 comment	Download
	M	pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Siggi Cherem (dart-lang)

lgtm https://codereview.chromium.org/2551713002/diff/1/pkg/compiler/lib/src/ssa/builder_kernel.dart File pkg/compiler/lib/src/ssa/builder_kernel.dart (left): https://codereview.chromium.org/2551713002/diff/1/pkg/compiler/lib/src/ssa/builder_kernel.dart#oldcode1250 pkg/compiler/lib/src/ssa/builder_kernel.dart:1250: unhandledForeign(invocation); woo hoo!

4 years ago (2016-12-04 05:02:41 UTC) #3

sra1

4 years ago (2016-12-05 19:03:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7207dcd3768fd8e6631d63b3a93573390766f9f4 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages