Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2551653002: Fix a bug in pinch handling of the tab switcher. (Closed)

Created:
4 years ago by xingliu
Modified:
4 years ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The whole tab stack disappears when the user pinch all tabs together and scroll to the top of the screen when we have multiple tabs. This is caused by Y position of the stack sets to NaN, where there is a division to 0 in the code. BUG=670897 Committed: https://crrev.com/531c3255a45abfa9b6a8a621c76b88c1f5b21a73 Cr-Commit-Position: refs/heads/master@{#436457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/Stack.java View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
xingliu
Fixed the stack disappearing bug when pinch.
4 years ago (2016-12-03 00:20:47 UTC) #6
David Trainor- moved to gerrit
lgtm great catch!
4 years ago (2016-12-05 21:38:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551653002/1
4 years ago (2016-12-05 22:53:05 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 23:45:19 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-05 23:47:04 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/531c3255a45abfa9b6a8a621c76b88c1f5b21a73
Cr-Commit-Position: refs/heads/master@{#436457}

Powered by Google App Engine
This is Rietveld 408576698