Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2551643002: In RandomOrderExpectations, skip tests that fail on Precise (Closed)

Created:
4 years ago by jeffcarp
Modified:
4 years ago
Reviewers:
qyearsley
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In RandomOrderExpectations, skip tests that fail on Precise These tests were originally skipped because they fail on Precise. When the CQ was upgraded from Precise to Trusty, these tests were unskipped. The RandomOrder Linux builder is still Precise, so we need to skip these until we upgrade it to Trusty. BUG=670841 R=qyearsley@chromium.org Committed: https://crrev.com/3bb2e052adf2adbb5ebbe4978c285d27e8e43ecc Cr-Commit-Position: refs/heads/master@{#436241}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/RandomOrderExpectations View 1 chunk +15 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
jeffcarp
4 years ago (2016-12-02 23:31:34 UTC) #1
qyearsley
lgtm https://codereview.chromium.org/2551643002/diff/1/third_party/WebKit/LayoutTests/RandomOrderExpectations File third_party/WebKit/LayoutTests/RandomOrderExpectations (right): https://codereview.chromium.org/2551643002/diff/1/third_party/WebKit/LayoutTests/RandomOrderExpectations#newcode157 third_party/WebKit/LayoutTests/RandomOrderExpectations:157: # Adding these temporarily until the Linux builder ...
4 years ago (2016-12-02 23:37:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551643002/1
4 years ago (2016-12-05 06:28:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 07:44:48 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-05 07:46:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3bb2e052adf2adbb5ebbe4978c285d27e8e43ecc
Cr-Commit-Position: refs/heads/master@{#436241}

Powered by Google App Engine
This is Rietveld 408576698