Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Unified Diff: Source/core/html/HTMLTextFormControlElement.cpp

Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/forms/checkbox-onchange-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLTextFormControlElement.cpp
diff --git a/Source/core/html/HTMLTextFormControlElement.cpp b/Source/core/html/HTMLTextFormControlElement.cpp
index c3f751a63f54d4eb643bdb97275b0ecbe1ae555c..179bf18f5dd386c5ea89f83d2bdb5f7bb175d53d 100644
--- a/Source/core/html/HTMLTextFormControlElement.cpp
+++ b/Source/core/html/HTMLTextFormControlElement.cpp
@@ -184,7 +184,7 @@ void HTMLTextFormControlElement::select()
void HTMLTextFormControlElement::dispatchFormControlChangeEvent()
{
- if (!equalIgnoringNullity(m_textAsOfLastFormControlChangeEvent, value())) {
+ if (!equalIgnoringNullity(m_textAsOfLastFormControlChangeEvent, value()) || (type() == "checkbox" && m_textAsOfLastFormControlChangeEvent != value())) {
tkent 2014/04/29 23:43:41 Please do not add input-type checking to HTMLTextF
dispatchChangeEvent();
setTextAsOfLastFormControlChangeEvent(value());
}
« no previous file with comments | « LayoutTests/fast/forms/checkbox-onchange-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698