Dispatch change event for input type=checkbox when checked but value is null

Source/core/html/HTMLTextFormControlElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 164 matching lines @@
 void HTMLTextFormControlElement::setSelectionDirection(const String& direction)
 {
     setSelectionRange(selectionStart(), selectionEnd(), direction);
 }
 
 void HTMLTextFormControlElement::select()
 {
     setSelectionRange(0, numeric_limits<int>::max(), SelectionHasNoDirection);
 }
 
+bool HTMLTextFormControlElement::shouldDispatchFormControlChangeEvent(String& oldValue, String& newValue)
+{
+    return false;
+}
+
 void HTMLTextFormControlElement::dispatchFormControlChangeEvent()
 {
-    if (!equalIgnoringNullity(m_textAsOfLastFormControlChangeEvent, value())) {
+    String newValue = value();
+    if (!equalIgnoringNullity(m_textAsOfLastFormControlChangeEvent, newValue)

[tkent, 2014/05/07 01:24:57]

The equalIgnoringNullity check should be in
HTMLTextFormControlElement::shouldDispatchFormControlChangeEvent and
InputType::shouldDispatchFormControlChangeEvent.

[keishi, 2014/05/07 01:26:11]

I think equalIgnoringNullity is part of the check required before dispatching
the change event. Is there any reason why this shouldn't be in
HTMLTextFormControlElement::shouldDispatchFormControlChangeEvent?

[Habib Virji, 2014/05/07 10:06:39]

Done.

[Habib Virji, 2014/05/07 10:06:39]

Done.

+        || shouldDispatchFormControlChangeEvent(m_textAsOfLastFormControlChangeEvent, newValue)) {
         dispatchChangeEvent();
-        setTextAsOfLastFormControlChangeEvent(value());
+        setTextAsOfLastFormControlChangeEvent(newValue);
     }
     setChangedSinceLastFormControlChangeEvent(false);
 }
 
 static inline bool hasVisibleTextArea(RenderObject* renderer, HTMLElement* innerText)
 {
     ASSERT(renderer);
     return renderer->style()->visibility() != HIDDEN && innerText && innerText->renderer() && innerText->renderBox()->height();
 }
 
@@ skipping 445 matching lines @@
 
     return "ltr";
 }
 
 HTMLElement* HTMLTextFormControlElement::innerTextElement() const
 {
     return toHTMLElement(userAgentShadowRoot()->getElementById(ShadowElementNames::innerEditor()));
 }
 
 } // namespace Webcore