LayoutTests/fast/forms/checkbox-onchange.html - Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/checkbox-onchange.html

Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed input type check and instead using virtual function to check if input type is checkbox Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../resources/js-test.js"></script>	4 <script src="../../resources/js-test.js"></script>

5 </head>	5 </head>

6 <body>	6 <body>

7 <input type="checkbox" id="ch" onchange="handleChange()">	7 <input type="checkbox" id="ch" onchange="handleChange()">

	8 <input type="checkbox" id="ch1" value="" onchange="handleChange()">

8 <script>	9 <script>

9 description("This is to test onchange of checkboxes");	10 description("This is to test onchange of checkboxes");

10	11

11 function handleChange() {	12 function handleChange() {

12 testPassed('onChange event fired for the checkbox.');	13 testPassed('onChange event fired for the checkbox.');

13 }	14 }

14	15

15 document.getElementById('ch').click();	16 document.getElementById('ch').click();

	17 document.getElementById('ch1').click();

16 </script>	18 </script>

17 </body>	19 </body>

18 </html>	20 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/forms/checkbox-onchange-expected.txt » ('j') | Source/core/html/HTMLTextFormControlElement.cpp » ('J')