Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: Source/core/html/forms/InputType.h

Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Moved shouldDispatchFormControlChangeEvent as private/protected function and moved shouldDispatch t… Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/forms/BaseCheckableInputType.cpp ('k') | Source/core/html/forms/InputType.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * Copyright (C) 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2011 Apple Inc. All rights reserved.
4 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 4 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions are 7 * modification, are permitted provided that the following conditions are
8 * met: 8 * met:
9 * 9 *
10 * * Redistributions of source code must retain the above copyright 10 * * Redistributions of source code must retain the above copyright
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 // element is image. It returns 0 if the element is not image type. 213 // element is image. It returns 0 if the element is not image type.
214 virtual unsigned height() const; 214 virtual unsigned height() const;
215 virtual unsigned width() const; 215 virtual unsigned width() const;
216 216
217 void dispatchSimulatedClickIfActive(KeyboardEvent*) const; 217 void dispatchSimulatedClickIfActive(KeyboardEvent*) const;
218 218
219 // InputTypeView override 219 // InputTypeView override
220 virtual bool shouldSubmitImplicitly(Event*) OVERRIDE; 220 virtual bool shouldSubmitImplicitly(Event*) OVERRIDE;
221 virtual bool hasCustomFocusLogic() const OVERRIDE; 221 virtual bool hasCustomFocusLogic() const OVERRIDE;
222 222
223 virtual bool shouldDispatchFormControlChangeEvent(String&, String&);
224
223 protected: 225 protected:
224 InputType(HTMLInputElement& element) : InputTypeView(element) { } 226 InputType(HTMLInputElement& element) : InputTypeView(element) { }
225 Chrome* chrome() const; 227 Chrome* chrome() const;
226 Locale& locale() const; 228 Locale& locale() const;
227 Decimal parseToNumberOrNaN(const String&) const; 229 Decimal parseToNumberOrNaN(const String&) const;
228 void countUsageIfVisible(UseCounter::Feature) const; 230 void countUsageIfVisible(UseCounter::Feature) const;
229 231
230 // Derive the step base, following the HTML algorithm steps. 232 // Derive the step base, following the HTML algorithm steps.
231 Decimal findStepBase(const Decimal&) const; 233 Decimal findStepBase(const Decimal&) const;
232 234
233 StepRange createStepRange(AnyStepHandling, const Decimal& stepBaseDefault, c onst Decimal& minimumDefault, const Decimal& maximumDefault, const StepRange::St epDescription&) const; 235 StepRange createStepRange(AnyStepHandling, const Decimal& stepBaseDefault, c onst Decimal& minimumDefault, const Decimal& maximumDefault, const StepRange::St epDescription&) const;
234 236
235 private: 237 private:
236 // Helper for stepUp()/stepDown(). Adds step value * count to the current va lue. 238 // Helper for stepUp()/stepDown(). Adds step value * count to the current va lue.
237 void applyStep(const Decimal&, int count, AnyStepHandling, TextFieldEventBeh avior, ExceptionState&); 239 void applyStep(const Decimal&, int count, AnyStepHandling, TextFieldEventBeh avior, ExceptionState&);
238 }; 240 };
239 241
240 } // namespace WebCore 242 } // namespace WebCore
241 #endif 243 #endif
OLDNEW
« no previous file with comments | « Source/core/html/forms/BaseCheckableInputType.cpp ('k') | Source/core/html/forms/InputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698