Source/core/html/forms/BaseCheckableInputType.h - Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/forms/BaseCheckableInputType.h

Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Moved shouldDispatchFormControlChangeEvent as private/protected function and moved shouldDispatch t… Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/html/HTMLTextFormControlElement.cpp ('k') | Source/core/html/forms/BaseCheckableInputType.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Google Inc. All rights reserved.	2 * Copyright (C) 2010 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
45 virtual FormControlState saveFormControlState() const OVERRIDE FINAL;	45 virtual FormControlState saveFormControlState() const OVERRIDE FINAL;

46 virtual void restoreFormControlState(const FormControlState&) OVERRIDE FINAL ;	46 virtual void restoreFormControlState(const FormControlState&) OVERRIDE FINAL ;

47 virtual bool appendFormData(FormDataList&, bool) const OVERRIDE FINAL;	47 virtual bool appendFormData(FormDataList&, bool) const OVERRIDE FINAL;

48 virtual void handleKeypressEvent(KeyboardEvent*) OVERRIDE FINAL;	48 virtual void handleKeypressEvent(KeyboardEvent*) OVERRIDE FINAL;

49 virtual bool canSetStringValue() const OVERRIDE FINAL;	49 virtual bool canSetStringValue() const OVERRIDE FINAL;

50 virtual void accessKeyAction(bool sendMouseEvents) OVERRIDE FINAL;	50 virtual void accessKeyAction(bool sendMouseEvents) OVERRIDE FINAL;

51 virtual String fallbackValue() const OVERRIDE FINAL;	51 virtual String fallbackValue() const OVERRIDE FINAL;

52 virtual bool storesValueSeparateFromAttribute() OVERRIDE FINAL;	52 virtual bool storesValueSeparateFromAttribute() OVERRIDE FINAL;

53 virtual void setValue(const String&, bool, TextFieldEventBehavior) OVERRIDE FINAL;	53 virtual void setValue(const String&, bool, TextFieldEventBehavior) OVERRIDE FINAL;

54 virtual bool isCheckable() OVERRIDE FINAL;	54 virtual bool isCheckable() OVERRIDE FINAL;

	55 virtual bool shouldDispatchFormControlChangeEvent(String&, String&) OVERRIDE ;

55 };	56 };

56	57

57 } // namespace WebCore	58 } // namespace WebCore

58	59

59 #endif // BaseCheckableInputType_h	60 #endif // BaseCheckableInputType_h

OLD	NEW