Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: Source/core/html/HTMLTextFormControlElement.cpp

Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Moved shouldDispatchFormControlChangeEvent as private/protected function and moved shouldDispatch t… Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 void HTMLTextFormControlElement::setSelectionDirection(const String& direction) 175 void HTMLTextFormControlElement::setSelectionDirection(const String& direction)
176 { 176 {
177 setSelectionRange(selectionStart(), selectionEnd(), direction); 177 setSelectionRange(selectionStart(), selectionEnd(), direction);
178 } 178 }
179 179
180 void HTMLTextFormControlElement::select() 180 void HTMLTextFormControlElement::select()
181 { 181 {
182 setSelectionRange(0, numeric_limits<int>::max(), SelectionHasNoDirection); 182 setSelectionRange(0, numeric_limits<int>::max(), SelectionHasNoDirection);
183 } 183 }
184 184
185 bool HTMLTextFormControlElement::shouldDispatchFormControlChangeEvent(String& ol dValue, String& newValue)
186 {
187 return !equalIgnoringNullity(oldValue, newValue);
188 }
189
185 void HTMLTextFormControlElement::dispatchFormControlChangeEvent() 190 void HTMLTextFormControlElement::dispatchFormControlChangeEvent()
186 { 191 {
187 if (!equalIgnoringNullity(m_textAsOfLastFormControlChangeEvent, value())) { 192 String newValue = value();
193 if (shouldDispatchFormControlChangeEvent(m_textAsOfLastFormControlChangeEven t, newValue)) {
188 dispatchChangeEvent(); 194 dispatchChangeEvent();
189 setTextAsOfLastFormControlChangeEvent(value()); 195 setTextAsOfLastFormControlChangeEvent(newValue);
190 } 196 }
191 setChangedSinceLastFormControlChangeEvent(false); 197 setChangedSinceLastFormControlChangeEvent(false);
192 } 198 }
193 199
194 static inline bool hasVisibleTextArea(RenderObject* renderer, HTMLElement* inner Text) 200 static inline bool hasVisibleTextArea(RenderObject* renderer, HTMLElement* inner Text)
195 { 201 {
196 ASSERT(renderer); 202 ASSERT(renderer);
197 return renderer->style()->visibility() != HIDDEN && innerText && innerText-> renderer() && innerText->renderBox()->height(); 203 return renderer->style()->visibility() != HIDDEN && innerText && innerText-> renderer() && innerText->renderBox()->height();
198 } 204 }
199 205
(...skipping 445 matching lines...) Expand 10 before | Expand all | Expand 10 after
645 651
646 return "ltr"; 652 return "ltr";
647 } 653 }
648 654
649 HTMLElement* HTMLTextFormControlElement::innerTextElement() const 655 HTMLElement* HTMLTextFormControlElement::innerTextElement() const
650 { 656 {
651 return toHTMLElement(userAgentShadowRoot()->getElementById(ShadowElementName s::innerEditor())); 657 return toHTMLElement(userAgentShadowRoot()->getElementById(ShadowElementName s::innerEditor()));
652 } 658 }
653 659
654 } // namespace Webcore 660 } // namespace Webcore
OLDNEW
« no previous file with comments | « Source/core/html/HTMLTextFormControlElement.h ('k') | Source/core/html/forms/BaseCheckableInputType.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698