Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: Source/core/html/HTMLInputElement.h

Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Moved shouldDispatchFormControlChangeEvent as private/protected function and moved shouldDispatch t… Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
6 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 6 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 358 matching lines...) Expand 10 before | Expand all | Expand 10 after
369 void updateValueIfNeeded(); 369 void updateValueIfNeeded();
370 370
371 // Returns null if this isn't associated with any radio button group. 371 // Returns null if this isn't associated with any radio button group.
372 RadioButtonGroupScope* radioButtonGroupScope() const; 372 RadioButtonGroupScope* radioButtonGroupScope() const;
373 void addToRadioButtonGroup(); 373 void addToRadioButtonGroup();
374 void removeFromRadioButtonGroup(); 374 void removeFromRadioButtonGroup();
375 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI) 375 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
376 virtual PassRefPtr<RenderStyle> customStyleForRenderer() OVERRIDE; 376 virtual PassRefPtr<RenderStyle> customStyleForRenderer() OVERRIDE;
377 #endif 377 #endif
378 378
379 virtual bool shouldDispatchFormControlChangeEvent(String&, String&) OVERRIDE ;
380
379 AtomicString m_name; 381 AtomicString m_name;
380 String m_valueIfDirty; 382 String m_valueIfDirty;
381 String m_suggestedValue; 383 String m_suggestedValue;
382 int m_size; 384 int m_size;
383 int m_maxLength; 385 int m_maxLength;
384 short m_maxResults; 386 short m_maxResults;
385 bool m_isChecked : 1; 387 bool m_isChecked : 1;
386 bool m_reflectsCheckedAttribute : 1; 388 bool m_reflectsCheckedAttribute : 1;
387 bool m_isIndeterminate : 1; 389 bool m_isIndeterminate : 1;
388 bool m_isActivatedSubmit : 1; 390 bool m_isActivatedSubmit : 1;
(...skipping 10 matching lines...) Expand all
399 RefPtr<InputTypeView> m_inputTypeView; 401 RefPtr<InputTypeView> m_inputTypeView;
400 // The ImageLoader must be owned by this element because the loader code ass umes 402 // The ImageLoader must be owned by this element because the loader code ass umes
401 // that it lives as long as its owning element lives. If we move the loader into 403 // that it lives as long as its owning element lives. If we move the loader into
402 // the ImageInput object we may delete the loader while this element lives o n. 404 // the ImageInput object we may delete the loader while this element lives o n.
403 OwnPtr<HTMLImageLoader> m_imageLoader; 405 OwnPtr<HTMLImageLoader> m_imageLoader;
404 OwnPtr<ListAttributeTargetObserver> m_listAttributeTargetObserver; 406 OwnPtr<ListAttributeTargetObserver> m_listAttributeTargetObserver;
405 }; 407 };
406 408
407 } //namespace 409 } //namespace
408 #endif 410 #endif
OLDNEW
« no previous file with comments | « LayoutTests/fast/forms/radio/radio-onchange-expected.txt ('k') | Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698