Source/core/html/HTMLInputElement.cpp - Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Moved shouldDispatchFormControlChangeEvent as private/protected function and moved shouldDispatch t… Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2001 Dirk Mueller (mueller@kde.org)	4 * (C) 2001 Dirk Mueller (mueller@kde.org)

5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.	5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.

6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)	6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)

7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)	7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)

8 * Copyright (C) 2010 Google Inc. All rights reserved.	8 * Copyright (C) 2010 Google Inc. All rights reserved.

9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)	9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)

10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.	10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.

(...skipping 1866 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1877 return m_inputType->isInteractiveContent();	1877 return m_inputType->isInteractiveContent();

1878 }	1878 }

1879	1879

1880 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)	1880 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)

1881 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer()	1881 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer()

1882 {	1882 {

1883 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer());	1883 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer());

1884 }	1884 }

1885 #endif	1885 #endif

1886	1886

	1887 bool HTMLInputElement::shouldDispatchFormControlChangeEvent(String& oldValue, St ring& newValue)

	1888 {

	1889 return m_inputType->shouldDispatchFormControlChangeEvent(oldValue, newValue) ;

	1890 }

	1891

1887 } // namespace	1892 } // namespace

OLD	NEW

« no previous file with comments | « Source/core/html/HTMLInputElement.h ('k') | Source/core/html/HTMLTextFormControlElement.h » ('j') | no next file with comments »