Source/core/html/HTMLTextFormControlElement.h - Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null

Side by Side Diff: Source/core/html/HTMLTextFormControlElement.h

Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added tests for Radio to check onchange event trigger Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2000 Dirk Mueller (mueller@kde.org)	4 * (C) 2000 Dirk Mueller (mueller@kde.org)

5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.	5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.

6 * Copyright (C) 2009, 2010, 2011 Google Inc. All rights reserved.	6 * Copyright (C) 2009, 2010, 2011 Google Inc. All rights reserved.

7 *	7 *

8 * This library is free software; you can redistribute it and/or	8 * This library is free software; you can redistribute it and/or

9 * modify it under the terms of the GNU Library General Public	9 * modify it under the terms of the GNU Library General Public

10 * License as published by the Free Software Foundation; either	10 * License as published by the Free Software Foundation; either

(...skipping 54 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
65 void setSelectionEnd(int);	65 void setSelectionEnd(int);

66 void setSelectionDirection(const String&);	66 void setSelectionDirection(const String&);

67 void select();	67 void select();

68 virtual void setRangeText(const String& replacement, ExceptionState&);	68 virtual void setRangeText(const String& replacement, ExceptionState&);

69 virtual void setRangeText(const String& replacement, unsigned start, unsigne d end, const String& selectionMode, ExceptionState&);	69 virtual void setRangeText(const String& replacement, unsigned start, unsigne d end, const String& selectionMode, ExceptionState&);

70 void setSelectionRange(int start, int end, const String& direction);	70 void setSelectionRange(int start, int end, const String& direction);

71 void setSelectionRange(int start, int end, TextFieldSelectionDirection = Sel ectionHasNoDirection);	71 void setSelectionRange(int start, int end, TextFieldSelectionDirection = Sel ectionHasNoDirection);

72 PassRefPtrWillBeRawPtr<Range> selection() const;	72 PassRefPtrWillBeRawPtr<Range> selection() const;

73	73

74 virtual void dispatchFormControlChangeEvent() OVERRIDE FINAL;	74 virtual void dispatchFormControlChangeEvent() OVERRIDE FINAL;

	75 virtual bool shouldDispatchFormControlChangeEvent(String&, String&);
	tkent 2014/05/07 10:09:56 This should be protected. This should be protected. Habib Virji 2014/05/07 10:27:10 Done. Show quoted text On 2014/05/07 10:09:56, tkent wrote: > This should be protected. Done.
75	76

76 virtual String value() const = 0;	77 virtual String value() const = 0;

77	78

78 HTMLElement* innerTextElement() const;	79 HTMLElement* innerTextElement() const;

79	80

80 void selectionChanged(bool userTriggered);	81 void selectionChanged(bool userTriggered);

81 bool lastChangeWasUserEdit() const;	82 bool lastChangeWasUserEdit() const;

82 virtual void setInnerTextValue(const String&);	83 virtual void setInnerTextValue(const String&);

83 String innerTextValue() const;	84 String innerTextValue() const;

84	85

(...skipping 55 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
140 return element.isTextFormControl();	141 return element.isTextFormControl();

141 }	142 }

142	143

143 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLTextFormControlElement);	144 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLTextFormControlElement);

144	145

145 HTMLTextFormControlElement* enclosingTextFormControl(const Position&);	146 HTMLTextFormControlElement* enclosingTextFormControl(const Position&);

146	147

147 } // namespace	148 } // namespace

148	149

149 #endif	150 #endif

OLD	NEW