Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: Source/core/html/HTMLInputElement.h

Issue 255163002: Dispatch change event for input type=checkbox when checked but value is null (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added tests for Radio to check onchange event trigger Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
6 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 6 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
272 bool hasImageLoader() const { return m_imageLoader; } 272 bool hasImageLoader() const { return m_imageLoader; }
273 HTMLImageLoader* imageLoader(); 273 HTMLImageLoader* imageLoader();
274 274
275 bool setupDateTimeChooserParameters(DateTimeChooserParameters&); 275 bool setupDateTimeChooserParameters(DateTimeChooserParameters&);
276 276
277 bool supportsInputModeAttribute() const; 277 bool supportsInputModeAttribute() const;
278 278
279 void setShouldRevealPassword(bool value); 279 void setShouldRevealPassword(bool value);
280 bool shouldRevealPassword() const { return m_shouldRevealPassword; } 280 bool shouldRevealPassword() const { return m_shouldRevealPassword; }
281 281
282 virtual bool shouldDispatchFormControlChangeEvent(String&, String&) OVERRIDE ;
tkent 2014/05/07 10:09:56 This should be private.
Habib Virji 2014/05/07 10:27:10 Done.
283
282 protected: 284 protected:
283 HTMLInputElement(Document&, HTMLFormElement*, bool createdByParser); 285 HTMLInputElement(Document&, HTMLFormElement*, bool createdByParser);
284 286
285 virtual void defaultEventHandler(Event*) OVERRIDE; 287 virtual void defaultEventHandler(Event*) OVERRIDE;
286 288
287 private: 289 private:
288 enum AutoCompleteSetting { Uninitialized, On, Off }; 290 enum AutoCompleteSetting { Uninitialized, On, Off };
289 291
290 virtual void didAddUserAgentShadowRoot(ShadowRoot&) OVERRIDE FINAL; 292 virtual void didAddUserAgentShadowRoot(ShadowRoot&) OVERRIDE FINAL;
291 virtual void willAddFirstAuthorShadowRoot() OVERRIDE FINAL; 293 virtual void willAddFirstAuthorShadowRoot() OVERRIDE FINAL;
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
399 RefPtr<InputTypeView> m_inputTypeView; 401 RefPtr<InputTypeView> m_inputTypeView;
400 // The ImageLoader must be owned by this element because the loader code ass umes 402 // The ImageLoader must be owned by this element because the loader code ass umes
401 // that it lives as long as its owning element lives. If we move the loader into 403 // that it lives as long as its owning element lives. If we move the loader into
402 // the ImageInput object we may delete the loader while this element lives o n. 404 // the ImageInput object we may delete the loader while this element lives o n.
403 OwnPtr<HTMLImageLoader> m_imageLoader; 405 OwnPtr<HTMLImageLoader> m_imageLoader;
404 OwnPtr<ListAttributeTargetObserver> m_listAttributeTargetObserver; 406 OwnPtr<ListAttributeTargetObserver> m_listAttributeTargetObserver;
405 }; 407 };
406 408
407 } //namespace 409 } //namespace
408 #endif 410 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698