Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2551613002:
Revert "Add temporary DumpWithoutCrashing to understand why the filesystem URL origin checks are fa… (Closed)
|
Created:
4 years ago by lfg Modified:
4 years ago Reviewers:
Charlie Reis CC:
chromium-reviews, jam, darin-cc_chromium.org, ncarter (slow) Target Ref:
refs/pending/branch-heads/2924 Project:
chromium Visibility:
Public. |
DescriptionRevert "Add temporary DumpWithoutCrashing to understand why the filesystem URL origin checks are failing in practice."
This reverts commit 0a66889a04ad4c87af24aeaa567184bd052227bd.
BUG=654479
NOTRY=true
NOPRESUBMIT=true
R=creis@chromium.org
Committed: https://chromium.googlesource.com/chromium/src/+/e4085dea2218d9110c806d78ca0488db3abe0491
Patch Set 1 #
Messages
Total messages: 20 (13 generated)
creis@chromium.org changed reviewers: + creis@chromium.org
Thanks! LGTM.
Charlie, can you take a look? As discussed in the bug, we are reverting this only on the M56 branch (2924) for now.
Description was changed from ========== Revert "Add temporary DumpWithoutCrashing to understand why the filesystem URL origin checks are failing in practice." This reverts commit 0a66889a04ad4c87af24aeaa567184bd052227bd. BUG=654479 ========== to ========== Revert "Add temporary DumpWithoutCrashing to understand why the filesystem URL origin checks are failing in practice." This reverts commit 0a66889a04ad4c87af24aeaa567184bd052227bd. BUG=654479 NOTRY=true NOPRESUBMIT=true ==========
The CQ bit was checked by lfg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480714700003080, "parent_rev":
"9c0f444ef635dd7ff040344e17ab102280ca0d20", "commit_rev":
"19ba2d3876722294c1c6acfa6edb85a240875e26"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480714700003080, "parent_rev":
"9c0f444ef635dd7ff040344e17ab102280ca0d20", "commit_rev":
"19ba2d3876722294c1c6acfa6edb85a240875e26"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480714700003080, "parent_rev":
"9c0f444ef635dd7ff040344e17ab102280ca0d20", "commit_rev":
"19ba2d3876722294c1c6acfa6edb85a240875e26"}
The CQ bit was unchecked by commit-bot@chromium.org
Failed to commit the patch.
The CQ bit was checked by lfg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480715567081370, "parent_rev":
"bc5a0884286e2efc084574dbe1ea7f51bb80afd0", "commit_rev":
"41274e694e1ebc5d70a6efa532f47c245ab787d3"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480715567081370, "parent_rev":
"bc5a0884286e2efc084574dbe1ea7f51bb80afd0", "commit_rev":
"41274e694e1ebc5d70a6efa532f47c245ab787d3"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480715567081370, "parent_rev":
"bc5a0884286e2efc084574dbe1ea7f51bb80afd0", "commit_rev":
"41274e694e1ebc5d70a6efa532f47c245ab787d3"}
The CQ bit was unchecked by commit-bot@chromium.org
Prior attempt to commit was detected, but we were not able to check whether the issue was successfully committed. Please check Git history manually and re-check CQ or close this issue as needed.
Description was changed from ========== Revert "Add temporary DumpWithoutCrashing to understand why the filesystem URL origin checks are failing in practice." This reverts commit 0a66889a04ad4c87af24aeaa567184bd052227bd. BUG=654479 NOTRY=true NOPRESUBMIT=true ========== to ========== Revert "Add temporary DumpWithoutCrashing to understand why the filesystem URL origin checks are failing in practice." This reverts commit 0a66889a04ad4c87af24aeaa567184bd052227bd. BUG=654479 NOTRY=true NOPRESUBMIT=true R=creis@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/e4085dea2218d9110c806d78ca04... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as e4085dea2218d9110c806d78ca0488db3abe0491 (presubmit successful). |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
