Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2551603002: Move QuicClock to quic/platform/ (Closed)

Created:
4 years ago by Ryan Hamilton
Modified:
4 years ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move QuicClock to quic/platform/ Merge internal change: 139517817 Merge internal change: 139517817 BUG= Committed: https://crrev.com/dfdb064889d13d4816f94d484a35902167cd6d05 Cr-Commit-Position: refs/heads/master@{#436160}

Patch Set 1 #

Patch Set 2 : missing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -267 lines) Patch
M net/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_network_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_chromium_alarm_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_chromium_packet_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/congestion_control/cubic.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/congestion_control/cubic_bytes.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/congestion_control/send_algorithm_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_buffered_packet_store.h View 1 chunk +1 line, -1 line 0 comments Download
D net/quic/core/quic_clock.h View 1 chunk +0 lines, -44 lines 0 comments Download
D net/quic/core/quic_clock.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M net/quic/core/quic_clock_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_stream_sequencer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/quic/platform/api/quic_clock.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/quic/platform/impl/quic_clock.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quartc/quartc_alarm_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quartc/quartc_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/test_tools/mock_clock.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_buffered_packet_store_peer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/simulator/actor.h View 1 chunk +1 line, -1 line 0 comments Download
A + net/tools/quic/platform/impl/quic_epoll_clock.h View 1 2 chunks +4 lines, -5 lines 0 comments Download
A + net/tools/quic/platform/impl/quic_epoll_clock.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/tools/quic/platform/impl/quic_epoll_clock_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_epoll_alarm_factory_test.cc View 1 chunk +1 line, -1 line 0 comments Download
D net/tools/quic/quic_epoll_clock.h View 1 chunk +0 lines, -50 lines 0 comments Download
D net/tools/quic/quic_epoll_clock.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D net/tools/quic/quic_epoll_clock_test.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M net/tools/quic/quic_epoll_connection_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_packet_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/quic/quic_simple_server.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.h View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (11 generated)
Ryan Hamilton
4 years ago (2016-12-02 20:54:56 UTC) #2
Zhongyi Shi
lgtm
4 years ago (2016-12-02 21:27:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551603002/1
4 years ago (2016-12-02 22:20:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/271581) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years ago (2016-12-02 22:27:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551603002/20001
4 years ago (2016-12-03 03:33:03 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-03 03:37:48 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-03 03:38:59 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dfdb064889d13d4816f94d484a35902167cd6d05
Cr-Commit-Position: refs/heads/master@{#436160}

Powered by Google App Engine
This is Rietveld 408576698