Issue 25516002: Remove npr.org quirk in HTMLMediaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25516002: Remove npr.org quirk in HTMLMediaElement (Closed)

Created:
7 years, 2 months ago by philipj_slow

Modified:
7 years, 2 months ago

Reviewers:
acolwell GONE FROM CHROMIUM, adamk

CC:
blink-reviews, feature-media-reviews_chromium.org, dglazkov+blink, nessy, vcarbune.chromium, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Remove npr.org quirk in HTMLMediaElement This quirk was added in <http://trac.webkit.org/changeset/58586>; with reference to <rdar://problem/7902467>. Unfortunately, the details are unavailable. It's likely that npr.org has changed since this was added, so try removing the quirk to see if anything breaks. BUG=302409 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158703

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -32 lines)			Patch
	M	Source/core/html/HTMLMediaElement.h	View		2 chunks	+0 lines, -3 lines	0 comments	Download
	M	Source/core/html/HTMLMediaElement.cpp	View		3 chunks	+0 lines, -29 lines	0 comments	Download

Total messages: 6 (0 generated)

adamk

lgtm Can you add a little more detail to the CL description (maybe just copy/paste ...

7 years, 2 months ago (2013-10-01 18:38:34 UTC) #3

philipj_slow

On 2013/10/01 18:38:34, adamk wrote: > lgtm > > Can you add a little more ...

7 years, 2 months ago (2013-10-02 07:25:42 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/25516002/1

7 years, 2 months ago (2013-10-02 07:30:44 UTC) #5

Message was sent while issue was closed.

Change committed as 158703