Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 2551573002: [Touch emulator] Update cursor when device scale factor changes. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
tdresser
CC:
chromium-reviews, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Touch emulator] Update cursor when device scale factor changes. This may fix a touch cursor problem when multiple monitors have different device scale factor. BUG=656915 Committed: https://crrev.com/689783cca804abbc079014f668aca55a7917e044 Cr-Commit-Position: refs/heads/master@{#436384}

Patch Set 1 #

Patch Set 2 : test, fix #

Patch Set 3 : other platforms #

Total comments: 2

Patch Set 4 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -16 lines) Patch
M content/browser/renderer_host/input/touch_emulator.h View 1 2 3 3 chunks +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/touch_emulator.cc View 1 2 chunks +30 lines, -15 lines 0 comments Download
M content/browser/renderer_host/input/touch_emulator_unittest.cc View 1 2 4 chunks +31 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
dgozman
Could you please take a look?
4 years ago (2016-12-02 19:53:17 UTC) #2
tdresser
"This may fix a touch cursor problem when multiple monitors have different device scale factor." ...
4 years ago (2016-12-05 16:55:01 UTC) #11
dgozman
https://codereview.chromium.org/2551573002/diff/40001/content/browser/renderer_host/input/touch_emulator.h File content/browser/renderer_host/input/touch_emulator.h (right): https://codereview.chromium.org/2551573002/diff/40001/content/browser/renderer_host/input/touch_emulator.h#newcode95 content/browser/renderer_host/input/touch_emulator.h:95: bool use_2x_cursors_; On 2016/12/05 16:55:01, tdresser wrote: > Move ...
4 years ago (2016-12-05 18:56:33 UTC) #12
dgozman
On 2016/12/05 16:55:01, tdresser wrote: > "This may fix a touch cursor problem when multiple ...
4 years ago (2016-12-05 18:59:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551573002/60001
4 years ago (2016-12-05 18:59:52 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-05 20:23:07 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-05 20:27:01 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/689783cca804abbc079014f668aca55a7917e044
Cr-Commit-Position: refs/heads/master@{#436384}

Powered by Google App Engine
This is Rietveld 408576698