Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2551553002: [ios] Adds activity_services resources (Closed)

Created:
4 years ago by sczs1
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds activity_services resources BUG=666732 Committed: https://crrev.com/65ac91af2b8d8ebb7595f5e354161088bb615093 Cr-Commit-Position: refs/heads/master@{#436030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
A ios/chrome/browser/ui/activity_services/BUILD.gn View 1 chunk +28 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/resources/activity_services_print.xcassets/Contents.json View 1 chunk +6 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/resources/activity_services_print.xcassets/activity_services_print.imageset/Contents.json View 1 chunk +32 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/activity_services/resources/activity_services_print.xcassets/activity_services_print.imageset/activity_services_print-60@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/activity_services/resources/activity_services_print.xcassets/activity_services_print.imageset/activity_services_print-60@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/activity_services/resources/activity_services_print.xcassets/activity_services_print.imageset/activity_services_print-76.png View Binary file 0 comments Download
A ios/chrome/browser/ui/activity_services/resources/activity_services_print.xcassets/activity_services_print.imageset/activity_services_print-76@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/activity_services/resources/activity_services_reading_list.png View Binary file 0 comments Download
A ios/chrome/browser/ui/activity_services/resources/activity_services_reading_list@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/activity_services/resources/activity_services_reading_list@3x.png View Binary file 0 comments Download

Messages

Total messages: 9 (4 generated)
sczs1
PTAL
4 years ago (2016-12-02 19:12:14 UTC) #2
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-02 19:58:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551553002/1
4 years ago (2016-12-02 19:59:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 21:27:16 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-02 21:30:00 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/65ac91af2b8d8ebb7595f5e354161088bb615093
Cr-Commit-Position: refs/heads/master@{#436030}

Powered by Google App Engine
This is Rietveld 408576698