Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Side by Side Diff: src/isolate.cc

Issue 255153002: JSObject::GetHiddenProperty() handlified. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/api.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdlib.h> 5 #include <stdlib.h>
6 6
7 #include "v8.h" 7 #include "v8.h"
8 8
9 #include "ast.h" 9 #include "ast.h"
10 #include "bootstrapper.h" 10 #include "bootstrapper.h"
(...skipping 1033 matching lines...) Expand 10 before | Expand all | Expand 10 after
1044 location = &potential_computed_location; 1044 location = &potential_computed_location;
1045 } 1045 }
1046 // It's not safe to try to make message objects or collect stack traces 1046 // It's not safe to try to make message objects or collect stack traces
1047 // while the bootstrapper is active since the infrastructure may not have 1047 // while the bootstrapper is active since the infrastructure may not have
1048 // been properly initialized. 1048 // been properly initialized.
1049 if (!bootstrapping) { 1049 if (!bootstrapping) {
1050 Handle<JSArray> stack_trace_object; 1050 Handle<JSArray> stack_trace_object;
1051 if (capture_stack_trace_for_uncaught_exceptions_) { 1051 if (capture_stack_trace_for_uncaught_exceptions_) {
1052 if (IsErrorObject(exception_handle)) { 1052 if (IsErrorObject(exception_handle)) {
1053 // We fetch the stack trace that corresponds to this error object. 1053 // We fetch the stack trace that corresponds to this error object.
1054 String* key = heap()->hidden_stack_trace_string(); 1054 Handle<String> key = factory()->hidden_stack_trace_string();
1055 Object* stack_property = 1055 Object* stack_property =
1056 JSObject::cast(*exception_handle)->GetHiddenProperty(key); 1056 JSObject::cast(*exception_handle)->GetHiddenProperty(key);
1057 // Property lookup may have failed. In this case it's probably not 1057 // Property lookup may have failed. In this case it's probably not
1058 // a valid Error object. 1058 // a valid Error object.
1059 if (stack_property->IsJSArray()) { 1059 if (stack_property->IsJSArray()) {
1060 stack_trace_object = Handle<JSArray>(JSArray::cast(stack_property)); 1060 stack_trace_object = Handle<JSArray>(JSArray::cast(stack_property));
1061 } 1061 }
1062 } 1062 }
1063 if (stack_trace_object.is_null()) { 1063 if (stack_trace_object.is_null()) {
1064 // Not an error object, we capture at throw site. 1064 // Not an error object, we capture at throw site.
(...skipping 1182 matching lines...) Expand 10 before | Expand all | Expand 10 after
2247 handle_scope_implementer()->IncrementCallDepth(); 2247 handle_scope_implementer()->IncrementCallDepth();
2248 if (run_microtasks) Execution::RunMicrotasks(this); 2248 if (run_microtasks) Execution::RunMicrotasks(this);
2249 for (int i = 0; i < call_completed_callbacks_.length(); i++) { 2249 for (int i = 0; i < call_completed_callbacks_.length(); i++) {
2250 call_completed_callbacks_.at(i)(); 2250 call_completed_callbacks_.at(i)();
2251 } 2251 }
2252 handle_scope_implementer()->DecrementCallDepth(); 2252 handle_scope_implementer()->DecrementCallDepth();
2253 } 2253 }
2254 2254
2255 2255
2256 } } // namespace v8::internal 2256 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698