OLD | NEW |
1 # Updating Clang format binaries | 1 # Updating Clang format binaries |
2 | 2 |
3 Instructions on how to update the [clang-format binaries](clang_format.md) that | 3 Instructions on how to update the [clang-format binaries](clang_format.md) that |
4 come with a checkout of Chromium. | 4 come with a checkout of Chromium. |
5 | 5 |
6 ## Prerequisites | 6 ## Prerequisites |
7 | 7 |
8 You'll need a Windows machine, a Linux machine, and a Mac; all capable of | 8 You'll need a Windows machine, a Linux machine, and a Mac; all capable of |
9 building clang-format. You'll also need permissions to upload to the appropriate | 9 building clang-format. You'll also need permissions to upload to the appropriate |
10 google storage bucket. Chromium infrastructure team members have this, and | 10 google storage bucket. Chromium infrastructure team members have this, and |
11 others can be granted the permission based on need. Talk to ncarter or hinoka | 11 others can be granted the permission based on need. Talk to ncarter or hinoka |
12 about getting access. | 12 about getting access. |
13 | 13 |
14 ## Pick a head svn revision | 14 ## Pick a head svn revision |
15 | 15 |
16 Consult http://llvm.org/svn/llvm-project/ for the current head revision. This | 16 Consult http://llvm.org/svn/llvm-project/ for the current head revision. This |
17 will be the CLANG_REV you'll use later to check out each platform to a | 17 will be the CLANG_REV you'll use later to check out each platform to a |
18 consistent state. | 18 consistent state. |
19 | 19 |
20 ## Build a release-mode clang-format on each platform | 20 ## Build a release-mode clang-format on each platform |
21 | 21 |
22 Follow the the official instructions here: | 22 Follow the official instructions here: |
23 http://clang.llvm.org/get_started.html. | 23 http://clang.llvm.org/get_started.html. |
24 | 24 |
25 Windows step-by-step: | 25 Windows step-by-step: |
26 | 26 |
27 ```shell | 27 ```shell |
28 # [double check you have the tools you need] | 28 # [double check you have the tools you need] |
29 where cmake.exe # You need to install this. | 29 where cmake.exe # You need to install this. |
30 where svn.exe # Maybe fix with: set PATH=%PATH%;D:\src\depot_tools\svn_bin | 30 where svn.exe # Maybe fix with: set PATH=%PATH%;D:\src\depot_tools\svn_bin |
31 "c:\Program Files (x86)\Microsoft Visual Studio 12.0\vc\vcvarsall.bat" amd64_x86 | 31 "c:\Program Files (x86)\Microsoft Visual Studio 12.0\vc\vcvarsall.bat" amd64_x86 |
32 | 32 |
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
115 The binaries were built at clang revision ####### on ####DATETIME####. | 115 The binaries were built at clang revision ####### on ####DATETIME####. |
116 | 116 |
117 BUG= | 117 BUG= |
118 | 118 |
119 The change should **always** include new `.sha1` files for each platform (we | 119 The change should **always** include new `.sha1` files for each platform (we |
120 want to keep these in lockstep), should **never** include `clang-format` | 120 want to keep these in lockstep), should **never** include `clang-format` |
121 binaries directly. The change should **always** update `README.chromium` | 121 binaries directly. The change should **always** update `README.chromium` |
122 | 122 |
123 clang-format binaries should weigh in at 1.5MB or less. Watch out for size | 123 clang-format binaries should weigh in at 1.5MB or less. Watch out for size |
124 regressions. | 124 regressions. |
OLD | NEW |