docs/linux_gtk_theme_integration.md - Issue 2551513002: Fix spelling mistakes in //docs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: docs/linux_gtk_theme_integration.md

Issue 2551513002: Fix spelling mistakes in //docs. (Closed)

Patch Set: Undo beng->being Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « docs/linux_eclipse_dev.md ('k') | docs/linux_profiling.md » ('j') | no next file with comments »

OLD	NEW
1 # Linux GTK Theme Integration	1 Linux GTK Theme Integration

2	2

3 The GTK+ port of Chromium has a mode where we try to match the user's GTK theme	3 The GTK+ port of Chromium has a mode where we try to match the user's GTK theme

4 (which can be enabled under Wrench -> Options -> Personal Stuff -> Set to GTK+	4 (which can be enabled under Wrench -> Options -> Personal Stuff -> Set to GTK+

5 theme). The heuristics often don't pick good colors due to a lack of information	5 theme). The heuristics often don't pick good colors due to a lack of information

6 in the GTK themes.	6 in the GTK themes.

7	7

8 Starting in Chrome 9, we're providing a new way for theme authors to control our	8 Starting in Chrome 9, we're providing a new way for theme authors to control our

9 GTK+ theming mode. I am not sure of the earliest build these showed up in, but I	9 GTK+ theming mode. I am not sure of the earliest build these showed up in, but I

10 know 9.0.597 works.	10 know 9.0.597 works.

11	11

(...skipping 114 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
126	126

127 `MetaFrames` is a class that was used in metacity to communicate color	127 `MetaFrames` is a class that was used in metacity to communicate color

128 information to the window manager. During the Hardy Heron days, we slurped up	128 information to the window manager. During the Hardy Heron days, we slurped up

129 the data and used it as a key part of our heuristics. At least on my Lucid Lynx	129 the data and used it as a key part of our heuristics. At least on my Lucid Lynx

130 machine, none of the GNOME GTK+ themes have `MetaFrames` styling. (As mentioned	130 machine, none of the GNOME GTK+ themes have `MetaFrames` styling. (As mentioned

131 above, several of the XFCE themes do, though.)	131 above, several of the XFCE themes do, though.)

132	132

133 Internally to chrome, our `ChromeGtkFrame` class inherits from `MetaFrames`	133 Internally to chrome, our `ChromeGtkFrame` class inherits from `MetaFrames`

134 (again, which inherits from `GtkWindow`) so any old themes that style the	134 (again, which inherits from `GtkWindow`) so any old themes that style the

135 `MetaFrames` class are backwards compatible.	135 `MetaFrames` class are backwards compatible.

OLD	NEW