Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Unified Diff: ios/web/shell/test/page_state_egtest.mm

Issue 2551503002: Disable testScrollPositionRestoring on iOS 9. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/shell/test/page_state_egtest.mm
diff --git a/ios/web/shell/test/page_state_egtest.mm b/ios/web/shell/test/page_state_egtest.mm
index 41f513e3562235eeceab20cf30ba2aa211395372..56916b0844af7e799e5feb5040a5733892cfd742 100644
--- a/ios/web/shell/test/page_state_egtest.mm
+++ b/ios/web/shell/test/page_state_egtest.mm
@@ -7,6 +7,8 @@
#import <Foundation/Foundation.h>
#import <XCTest/XCTest.h>
+#include "base/ios/ios_util.h"
+#import "ios/testing/earl_grey/disabled_test_macros.h"
#import "ios/web/public/test/http_server.h"
#include "ios/web/public/test/http_server_util.h"
#import "ios/web/shell/test/earl_grey/shell_base_test_case.h"
@@ -58,6 +60,10 @@ using web::test::HttpServer;
// Tests that page scroll position of a page is restored upon returning to the
// page via the back/forward buttons.
- (void)testScrollPositionRestoring {
+ // TODO(crbug.com/670700): Re-enable this test.
+ if (!base::ios::IsRunningOnIOS10OrLater()) {
Eugene But (OOO till 7-30) 2016/12/02 16:50:36 Is it flaky on both device and simulator?
+ EARL_GREY_TEST_DISABLED(@"Test disabled on pre-iOS 10");
+ }
web::test::SetUpFileBasedHttpServer();
// Load first URL which is a long page.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698