Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2551503002: Disable testScrollPositionRestoring on iOS 9. (Closed)

Created:
4 years ago by baxley
Modified:
4 years ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable testScrollPositionRestoring on iOS 9. This test is flaky on iOS 9, but works on iOS 10. BUG=670700 Committed: https://crrev.com/c654fbbf22e44c70cefdf01e9bdfffaabf837996 Cr-Commit-Position: refs/heads/master@{#435960}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ios/web/shell/test/page_state_egtest.mm View 2 chunks +6 lines, -0 lines 1 comment Download

Messages

Total messages: 11 (4 generated)
baxley
4 years ago (2016-12-02 16:46:35 UTC) #2
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2551503002/diff/1/ios/web/shell/test/page_state_egtest.mm File ios/web/shell/test/page_state_egtest.mm (right): https://codereview.chromium.org/2551503002/diff/1/ios/web/shell/test/page_state_egtest.mm#newcode64 ios/web/shell/test/page_state_egtest.mm:64: if (!base::ios::IsRunningOnIOS10OrLater()) { Is it flaky on both ...
4 years ago (2016-12-02 16:50:36 UTC) #3
baxley
On 2016/12/02 16:50:36, Eugene But wrote: > lgtm > > https://codereview.chromium.org/2551503002/diff/1/ios/web/shell/test/page_state_egtest.mm > File ios/web/shell/test/page_state_egtest.mm (right): ...
4 years ago (2016-12-02 16:53:13 UTC) #4
baxley
On 2016/12/02 16:53:13, baxley wrote: > On 2016/12/02 16:50:36, Eugene But wrote: > > lgtm ...
4 years ago (2016-12-02 16:53:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551503002/1
4 years ago (2016-12-02 17:01:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 17:11:40 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-02 17:14:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c654fbbf22e44c70cefdf01e9bdfffaabf837996
Cr-Commit-Position: refs/heads/master@{#435960}

Powered by Google App Engine
This is Rietveld 408576698