Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2551463002: [wasm] Move all V8-specific limitations to wasm-limits.h (Closed)

Created:
4 years ago by titzer
Modified:
4 years ago
Reviewers:
Clemens Hammacher
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Move all V8-specific limitations to wasm-limits.h R=clemensh@chromium.org BUG= Committed: https://crrev.com/d9cfd7757e429a55b5a0847e9f5a9c9b925ff5ff Cr-Commit-Position: refs/heads/master@{#41477}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -37 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/wasm/module-decoder.cc View 6 chunks +15 lines, -14 lines 0 comments Download
M src/wasm/wasm-interpreter.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/wasm/wasm-js.cc View 2 chunks +2 lines, -1 line 0 comments Download
A src/wasm/wasm-limits.h View 1 chunk +32 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.h View 2 chunks +0 lines, -11 lines 0 comments Download
M src/wasm/wasm-module.cc View 6 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
titzer
4 years ago (2016-12-02 14:01:55 UTC) #1
Clemens Hammacher
lgtm
4 years ago (2016-12-05 08:57:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551463002/1
4 years ago (2016-12-05 09:35:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 10:02:30 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-05 10:02:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9cfd7757e429a55b5a0847e9f5a9c9b925ff5ff
Cr-Commit-Position: refs/heads/master@{#41477}

Powered by Google App Engine
This is Rietveld 408576698