Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2551433002: [wasm] Avoid using const that triggers ignition and flakes on ARM. (Closed)

Created:
4 years ago by titzer
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Avoid using const that triggers ignition and flakes on ARM. R=machenbach@chromium.org,jarin@chromium.org BUG=v8:5710 Committed: https://crrev.com/e454742d7c2c456af1adfee591a6b4a3aa2d0ab9 Cr-Commit-Position: refs/heads/master@{#41454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M test/mjsunit/wasm/asm-wasm-f32.js View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
titzer
4 years ago (2016-12-02 13:28:21 UTC) #1
Michael Achenbach
lgtm
4 years ago (2016-12-02 13:35:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551433002/1
4 years ago (2016-12-02 13:36:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 13:54:36 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-02 13:54:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e454742d7c2c456af1adfee591a6b4a3aa2d0ab9
Cr-Commit-Position: refs/heads/master@{#41454}

Powered by Google App Engine
This is Rietveld 408576698