third_party/WebKit/LayoutTests/inspector/elements/shadow/breadcrumb-shadow-roots.html - Issue 2551403002: [DevTools] ElementsBreadcrumbs Perf Improvements & Cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/elements/shadow/breadcrumb-shadow-roots.html

Issue 2551403002: [DevTools] ElementsBreadcrumbs Perf Improvements & Cleanup (Closed)

Patch Set: address feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/elements/breadcrumb-updates.html ('k') | third_party/WebKit/Source/devtools/front_end/elements/ElementsBreadcrumbs.js » ('j') | third_party/WebKit/Source/devtools/front_end/elements/ElementsBreadcrumbs.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/elements/shadow/breadcrumb-shadow-roots.html

diff --git a/third_party/WebKit/LayoutTests/inspector/elements/shadow/breadcrumb-shadow-roots.html b/third_party/WebKit/LayoutTests/inspector/elements/shadow/breadcrumb-shadow-roots.html

index ba2692178c3da475ab2f911a3f385408f6f031f0..6cc5dbf394368a272e936d1b042b6c30aeda0e78 100644

--- a/third_party/WebKit/LayoutTests/inspector/elements/shadow/breadcrumb-shadow-roots.html

+++ b/third_party/WebKit/LayoutTests/inspector/elements/shadow/breadcrumb-shadow-roots.html

@@ -48,7 +48,8 @@ function test()

InspectorTest.findNode(matchFunction, callback);

function callback(node)

{

- Common.Revealer.revealPromise(node).then(next);

+ InspectorTest.addSniffer(Elements.ElementsBreadcrumbs.prototype, "update", next);

+ Common.Revealer.revealPromise(node);

}