Disable supervised user creation when force sign in is enabled.

chrome/browser/supervised_user/supervised_user_creation_policy_handler_unittest.cc

Index: chrome/browser/supervised_user/supervised_user_creation_policy_handler_unittest.cc
diff --git a/chrome/browser/supervised_user/supervised_user_creation_policy_handler_unittest.cc b/chrome/browser/supervised_user/supervised_user_creation_policy_handler_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a42a224d1a4a5a73a4d9b0f3d1a5355860c2f3fb
--- /dev/null
+++ b/chrome/browser/supervised_user/supervised_user_creation_policy_handler_unittest.cc
@@ -0,0 +1,99 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/supervised_user/supervised_user_creation_policy_handler.h"
+
+#include "base/memory/ptr_util.h"
+#include "base/values.h"
+#include "chrome/common/pref_names.h"
+#include "components/policy/core/common/policy_map.h"
+#include "components/policy/policy_constants.h"
+#include "components/prefs/pref_value_map.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace policy {
+
+class SupervisedUserCreationPolicyHandlerTest : public ::testing::Test {
+ protected:
+  void SetUpPolicy(const char* policy_name, bool value) {
+    policies_.Set(policy_name, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
+                  POLICY_SOURCE_PLATFORM,
+                  base::MakeUnique<base::FundamentalValue>(value), nullptr);
+  }
+
+  void ApplyPolicySettings() {
+    handler_.ApplyPolicySettings(policies_, &prefs_);

[Marc Treib, 2016/12/06 17:13:40]

optional: Looks like every call to SetUpPolicy is immediately followed by a call
to ApplyPolicySettings, so SetUpPolicy could just call ApplyPolicySettings.

[zmin, 2016/12/06 17:33:35]

Done. And I rename the SetUpPolicy to SetUpPolicyAndApply

+  }
+
+  PrefValueMap* prefs() { return &prefs_; }
+
+ private:
+  PolicyMap policies_;
+  PrefValueMap prefs_;
+  SupervisedUserCreationPolicyHandler handler_;
+};
+
+TEST_F(SupervisedUserCreationPolicyHandlerTest, ForceSigninNotSet) {
+  ApplyPolicySettings();
+  EXPECT_FALSE(
+      prefs()->GetValue(prefs::kSupervisedUserCreationAllowed, nullptr));
+
+  bool value;
+  SetUpPolicy(key::kSupervisedUserCreationEnabled, true);
+  ApplyPolicySettings();
+  EXPECT_TRUE(
+      prefs()->GetBoolean(prefs::kSupervisedUserCreationAllowed, &value));
+  EXPECT_TRUE(value);
+
+  SetUpPolicy(key::kSupervisedUserCreationEnabled, false);
+  ApplyPolicySettings();
+  EXPECT_TRUE(
+      prefs()->GetBoolean(prefs::kSupervisedUserCreationAllowed, &value));
+  EXPECT_FALSE(value);
+}
+
+TEST_F(SupervisedUserCreationPolicyHandlerTest, ForceSigninDisabled) {
+  SetUpPolicy(key::kForceBrowserSignin, false);
+  ApplyPolicySettings();
+  EXPECT_FALSE(
+      prefs()->GetValue(prefs::kSupervisedUserCreationAllowed, nullptr));
+
+  bool value;
+  SetUpPolicy(key::kSupervisedUserCreationEnabled, true);
+  ApplyPolicySettings();
+  EXPECT_TRUE(
+      prefs()->GetBoolean(prefs::kSupervisedUserCreationAllowed, &value));
+  EXPECT_TRUE(value);
+
+  SetUpPolicy(key::kSupervisedUserCreationEnabled, false);
+  ApplyPolicySettings();
+  EXPECT_TRUE(
+      prefs()->GetBoolean(prefs::kSupervisedUserCreationAllowed, &value));
+  EXPECT_FALSE(value);
+}
+
+TEST_F(SupervisedUserCreationPolicyHandlerTest, ForceSigninEnabled) {
+  bool value;
+  SetUpPolicy(key::kForceBrowserSignin, true);
+  ApplyPolicySettings();
+  EXPECT_TRUE(
+      prefs()->GetBoolean(prefs::kSupervisedUserCreationAllowed, &value));
+  EXPECT_FALSE(value);
+
+  // When force sign in is enabled, the supervised user creation will be
+  // disabled even the policy is set to true.

[Marc Treib, 2016/12/06 17:13:40]

nit: s/even/even if/

[zmin, 2016/12/06 17:33:35]

Done.

+  SetUpPolicy(key::kSupervisedUserCreationEnabled, true);
+  ApplyPolicySettings();
+  EXPECT_TRUE(
+      prefs()->GetBoolean(prefs::kSupervisedUserCreationAllowed, &value));
+  EXPECT_FALSE(value);
+
+  SetUpPolicy(key::kSupervisedUserCreationEnabled, false);
+  ApplyPolicySettings();
+  EXPECT_TRUE(
+      prefs()->GetBoolean(prefs::kSupervisedUserCreationAllowed, &value));
+  EXPECT_FALSE(value);
+}
+
+}  // namespace policy