Disable supervised user creation when force sign in is enabled.

chrome/browser/supervised_user/supervised_user_creation_policy_handler_unittest.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/supervised_user/supervised_user_creation_policy_handler.h"
+
+#include "base/memory/ptr_util.h"
+#include "base/values.h"
+#include "chrome/common/pref_names.h"
+#include "components/policy/core/common/policy_map.h"
+#include "components/policy/policy_constants.h"
+#include "components/prefs/pref_value_map.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace policy {
+
+class SupervisedUserCreationPolicyHandlerTest : public ::testing::Test {
+ public:
+  void SetUp() override {
+    prefs_.Clear();
+    policies_.Clear();

[Marc Treib, 2016/12/06 09:28:37]

I don't think this is necessary, these shouldn't survive across tests anyway?

[zmin, 2016/12/06 17:04:55]

Removed.

+  }
+
+ protected:
+  void SetUpPolicy(const char* policy_name, bool value) {
+    policies_.Set(policy_name, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
+                  POLICY_SOURCE_PLATFORM,
+                  base::MakeUnique<base::FundamentalValue>(value), nullptr);
+  }
+
+  PolicyMap policies_;
+  PrefValueMap prefs_;
+  SupervisedUserCreationPolicyHandler handler_;
+};
+
+TEST_F(SupervisedUserCreationPolicyHandlerTest, ForceSigninNotSet) {
+  handler_.ApplyPolicySettings(policies_, &prefs_);

[Marc Treib, 2016/12/06 09:28:36]

Maybe make a helper method for this, and make policies_ and prefs_ private?

[zmin, 2016/12/06 17:04:55]

Done.

+  EXPECT_FALSE(prefs_.GetValue(prefs::kSupervisedUserCreationAllowed, nullptr));

[Marc Treib, 2016/12/06 09:28:36]

Should this also test that setting the key::kSupervisedUserCreationEnabled
policy works?

[zmin, 2016/12/06 17:04:55]

Done.

+}
+
+TEST_F(SupervisedUserCreationPolicyHandlerTest, ForceSigninDisabled) {
+  SetUpPolicy(key::kForceBrowserSignin, false);
+  handler_.ApplyPolicySettings(policies_, &prefs_);
+  EXPECT_FALSE(prefs_.GetValue(prefs::kSupervisedUserCreationAllowed, nullptr));
+
+  bool value;
+  SetUpPolicy(key::kSupervisedUserCreationEnabled, true);
+  handler_.ApplyPolicySettings(policies_, &prefs_);
+  EXPECT_TRUE(prefs_.GetBoolean(prefs::kSupervisedUserCreationAllowed, &value));
+  EXPECT_TRUE(value);
+
+  SetUpPolicy(key::kSupervisedUserCreationEnabled, false);
+  handler_.ApplyPolicySettings(policies_, &prefs_);
+  EXPECT_TRUE(prefs_.GetBoolean(prefs::kSupervisedUserCreationAllowed, &value));
+  EXPECT_FALSE(value);
+}
+
+TEST_F(SupervisedUserCreationPolicyHandlerTest, ForceSigninEnabled) {
+  bool value;
+  SetUpPolicy(key::kForceBrowserSignin, true);
+  handler_.ApplyPolicySettings(policies_, &prefs_);
+  EXPECT_TRUE(prefs_.GetBoolean(prefs::kSupervisedUserCreationAllowed, &value));
+  EXPECT_FALSE(value);
+
+  SetUpPolicy(key::kSupervisedUserCreationEnabled, true);
+  handler_.ApplyPolicySettings(policies_, &prefs_);
+  EXPECT_TRUE(prefs_.GetBoolean(prefs::kSupervisedUserCreationAllowed, &value));
+  EXPECT_FALSE(value);

[Marc Treib, 2016/12/06 09:28:37]

IMO this deserves a comment.

[zmin, 2016/12/06 17:04:55]

Done.

+
+  SetUpPolicy(key::kSupervisedUserCreationEnabled, false);
+  handler_.ApplyPolicySettings(policies_, &prefs_);
+  EXPECT_TRUE(prefs_.GetBoolean(prefs::kSupervisedUserCreationAllowed, &value));
+  EXPECT_FALSE(value);
+}
+
+}  // namespace policy
+