Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2551323003: [wasm] Names of exported functions should be the stringified function index. (Closed)

Created:
4 years ago by titzer
Modified:
4 years ago
Reviewers:
bradnelson, rossberg
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Names of exported functions should be the stringified function index. R=bradnelson@chromium.org,rossberg@chromium.org BUG=v8:5705 Committed: https://crrev.com/f897e36c8cc2c7bcd29aa8b2eb09e0e140ad3f0a Cr-Commit-Position: refs/heads/master@{#41530}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -22 lines) Patch
M src/wasm/wasm-module.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M src/wasm/wasm-objects.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/wasm/wasm-objects.cc View 2 chunks +15 lines, -2 lines 1 comment Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +2 lines, -3 lines 0 comments Download
M test/mjsunit/wasm/export-table.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/function-prototype.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/indirect-tables.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
titzer
4 years ago (2016-12-06 14:34:29 UTC) #1
bradnelson
lgtm https://codereview.chromium.org/2551323003/diff/1/src/wasm/wasm-objects.cc File src/wasm/wasm-objects.cc (right): https://codereview.chromium.org/2551323003/diff/1/src/wasm/wasm-objects.cc#newcode314 src/wasm/wasm-objects.cc:314: ScopedVector<char> buffer(16); But you can have up to ...
4 years ago (2016-12-06 15:28:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551323003/1
4 years ago (2016-12-06 15:31:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 15:33:34 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-06 15:33:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f897e36c8cc2c7bcd29aa8b2eb09e0e140ad3f0a
Cr-Commit-Position: refs/heads/master@{#41530}

Powered by Google App Engine
This is Rietveld 408576698