Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2551323002: [Devtools] Fixes pressing CTRL in styles while editing deselects (Closed)

Created:
4 years ago by allada
Modified:
4 years ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixes pressing CTRL in styles while editing deselects This patch fixes a bug where if you click into a style to edit it and press ctrl while mouse-moving it will deselect your selection. R=lushnikov BUG=668850 Committed: https://crrev.com/d585c64d2fa26f6fad56d903c322bb6f90a324cb Cr-Commit-Position: refs/heads/master@{#436445}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 12 (6 generated)
allada
PTL
4 years ago (2016-12-05 22:02:31 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/2551323002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/2551323002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode1116 third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:1116: if (this._parentPane._isEditingStyle) should this check be in the ...
4 years ago (2016-12-05 22:22:09 UTC) #4
allada
https://codereview.chromium.org/2551323002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/2551323002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode1116 third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:1116: if (this._parentPane._isEditingStyle) On 2016/12/05 22:22:09, lushnikov wrote: > should ...
4 years ago (2016-12-05 22:40:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551323002/1
4 years ago (2016-12-05 22:40:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 23:24:19 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-05 23:27:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d585c64d2fa26f6fad56d903c322bb6f90a324cb
Cr-Commit-Position: refs/heads/master@{#436445}

Powered by Google App Engine
This is Rietveld 408576698