[Devtools] Fixes pressing CTRL in styles while editing deselects

[Devtools] Fixes pressing CTRL in styles while editing deselects

This patch fixes a bug where if you click into a style to edit it and
press ctrl while mouse-moving it will deselect your selection.

R=lushnikov
BUG=668850
Committed: https://crrev.com/d585c64d2fa26f6fad56d903c322bb6f90a324cb
Cr-Commit-Position: refs/heads/master@{#436445}

[allada, 2016-12-05 22:02:26]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[allada, 2016-12-05 22:02:31]

PTL

[commit-bot: I haz the power, 2016-12-05 22:03:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-12-05 22:22:09]

lgtm

https://codereview.chromium.org/2551323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
(right):

https://codereview.chromium.org/2551323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:1116:
if (this._parentPane._isEditingStyle)
should this check be in the very beginning of the method?

[allada, 2016-12-05 22:40:12]

https://codereview.chromium.org/2551323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
(right):

https://codereview.chromium.org/2551323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:1116:
if (this._parentPane._isEditingStyle)
On 2016/12/05 22:22:09, lushnikov wrote:
> should this check be in the very beginning of the method?

No, the code above this mostly affects non-selector items which we want to keep
the way it is.

[allada, 2016-12-05 22:40:18]

The CQ bit was unchecked by allada@chromium.org

[allada, 2016-12-05 22:40:23]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2016-12-05 22:40:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 23:23:55]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480977623944240, "parent_rev":
"c43c49e1ff4b0c91407aa8471e99d274132554fd", "commit_rev":
"c050a33a6de8d78058be1fd677da06219ac7fc71"}

[commit-bot: I haz the power, 2016-12-05 23:24:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-05 23:27:40]

Description was changed from

==========
[Devtools] Fixes pressing CTRL in styles while editing deselects

This patch fixes a bug where if you click into a style to edit it and
press ctrl while mouse-moving it will deselect your selection.

R=lushnikov
BUG=668850
==========

to

==========
[Devtools] Fixes pressing CTRL in styles while editing deselects

This patch fixes a bug where if you click into a style to edit it and
press ctrl while mouse-moving it will deselect your selection.

R=lushnikov
BUG=668850

Committed: https://crrev.com/d585c64d2fa26f6fad56d903c322bb6f90a324cb
Cr-Commit-Position: refs/heads/master@{#436445}
==========

[commit-bot: I haz the power, 2016-12-05 23:27:41]

Patchset 1 (id:??) landed as
https://crrev.com/d585c64d2fa26f6fad56d903c322bb6f90a324cb
Cr-Commit-Position: refs/heads/master@{#436445}