Index: chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc |
diff --git a/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc b/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc |
index 745f2b992b4d19168d49907875e098a19ba37f6b..135540c6015a81a7635b6b85e5ec50423411931c 100644 |
--- a/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc |
+++ b/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc |
@@ -271,19 +271,8 @@ void ChromeExtensionsDispatcherDelegate::RequireAdditionalModules( |
extensions::ScriptContext* context, |
bool is_within_platform_app) { |
extensions::ModuleSystem* module_system = context->module_system(); |
tapted
2016/12/06 23:28:36
nit: move into the `if` below, or just remove the
benwells
2016/12/16 02:22:36
Done.
|
- extensions::Feature::Context context_type = context->context_type(); |
// TODO(kalman, fsamuel): Eagerly calling Require on context startup is |
benwells
2016/12/06 09:22:12
Oops, I should keep this comment (maybe remove kal
tapted
2016/12/06 23:28:36
ack - might be good to move it inside the `if` too
benwells
2016/12/16 02:22:36
Done.
|
- // expensive. It would be better if there were a light way of detecting when |
- // a webview or appview is created and only then set up the infrastructure. |
- if (context_type == extensions::Feature::BLESSED_EXTENSION_CONTEXT && |
- is_within_platform_app && |
- extensions::GetCurrentChannel() <= version_info::Channel::DEV && |
- base::CommandLine::ForCurrentProcess()->HasSwitch( |
- extensions::switches::kEnableAppWindowControls)) { |
- module_system->Require("windowControls"); |
- } |
- |
// Note: setting up the WebView class here, not the chrome.webview API. |
// The API will be automatically set up when first used. |
if (context->GetAvailability("webViewInternal").is_available()) { |