Issue 25513003: reland r1743 with reverted test case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25513003: reland r1743 with reverted test case (Closed)

Created:
7 years, 2 months ago by ericvw

Modified:
7 years, 2 months ago

Reviewers:
Nico, scottmg

CC:
gyp-developer_googlegroups.com, Shezan Baig (Bloomberg)

Base URL:
https://chromium.googlesource.com/external/gyp.git@master

Visibility:
Public.

reland r1743 with reverted test case From https://codereview.chromium.org/24792003, it was identified that the test case change broke on mac platforms for the xcode generator. Since the xcode generator does not perform any translations for -l prefixed names in 'libraries', using STATIC_LIB_(PRE|SUF)FIX is the best course usage going forward at this time. R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1750

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -3 lines)			Patch
M	pylib/gyp/generator/ninja.py	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pylib/gyp/msvs_emulation.py	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/library_dirs/gyptest-library-dirs.py	View	1 2	2 chunks	+17 lines, -0 lines	0 comments	Download
A	test/library_dirs/subdir/test-win.gyp	View	1 2	1 chunk	+60 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

ericvw

Relanding r1743 from https://codereview.chromium.org/24792003. In patch set 2, the test case has been reverted so ...

7 years, 2 months ago (2013-10-04 21:07:18 UTC) #1

Message was sent while issue was closed.

Committed patchset #3 manually as r1750.