Add a new flag for slimming paint invalidation

Add a new flag for slimming paint invalidation

Slimming paint invalidation is a new system for paint invalidation
(see: https://goo.gl/eQczQW). It currently passes 99% of our paint
invalidation tests but is not yet mature enough to enable. This
patch adds a new flag temporarily to enable slimming paint
invalidation to test on more devices.

BUG=646176
TEST=unit_tests --gtest_filter="*AboutFlagsHistogramTest*"

Committed: https://crrev.com/8c9a7c78b3c45d14624a4bf9a1d85a60c0eb23b0
Cr-Commit-Position: refs/heads/master@{#437098}

[pdr., 2016-12-05 21:48:31]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, wangxianzhu@chromium.org

[Xianzhu, 2016-12-05 21:56:57]

lgtm

[pdr., 2016-12-05 23:19:08]

pdr@chromium.org changed reviewers:
+ creis@chromium.org

[pdr., 2016-12-05 23:19:48]

Thanks Xianzhu.

@creis, you are an owner of content/. Can you please review this?

[pdr., 2016-12-06 23:43:38]

On 2016/12/05 at 23:19:48, pdr. wrote:
> Thanks Xianzhu.
> 
> @creis, you are an owner of content/. Can you please review this?

Ping

[Charlie Reis, 2016-12-07 01:17:32]

content/ LGTM.

[pdr., 2016-12-07 01:41:56]

pdr@chromium.org changed reviewers:
+ jochen@chromium.org

[pdr., 2016-12-07 01:42:27]

Oops, need a reviewer or chrome/ too.

@jochen, you are an owner of chrome/. Can you take a look?

[jochen (gone - plz use gerrit), 2016-12-07 15:36:33]

can you reference a tracking bug from the CL description?

chrome/ lgtm, but you might need to modify histograms.xml? A unit test should
fail if yes. If you end up modifying histograms.xml, please ask an OWNERS of
tools/metrics to approve that change, as I can only approve UseCounter additions
to histograms

[pdr., 2016-12-07 20:20:11]

Description was changed from

==========
Add a new flag for slimming paint invalidation

Slimming paint invalidation is a new system for paint invalidation
(see: https://goo.gl/eQczQW). It currently passes 99% of our paint
invalidation tests but is not yet mature enough to enable. This
patch adds a new flag temporarily to enable slimming paint
invalidation to test on more devices.
==========

to

==========
Add a new flag for slimming paint invalidation

Slimming paint invalidation is a new system for paint invalidation
(see: https://goo.gl/eQczQW). It currently passes 99% of our paint
invalidation tests but is not yet mature enough to enable. This
patch adds a new flag temporarily to enable slimming paint
invalidation to test on more devices.

BUG=646176
==========

[pdr., 2016-12-07 20:33:01]

Description was changed from

==========
Add a new flag for slimming paint invalidation

Slimming paint invalidation is a new system for paint invalidation
(see: https://goo.gl/eQczQW). It currently passes 99% of our paint
invalidation tests but is not yet mature enough to enable. This
patch adds a new flag temporarily to enable slimming paint
invalidation to test on more devices.

BUG=646176
==========

to

==========
Add a new flag for slimming paint invalidation

Slimming paint invalidation is a new system for paint invalidation
(see: https://goo.gl/eQczQW). It currently passes 99% of our paint
invalidation tests but is not yet mature enough to enable. This
patch adds a new flag temporarily to enable slimming paint
invalidation to test on more devices.

BUG=646176
TEST=unit_tests --gtest_filter="*AboutFlagsHistogramTest*"
==========

[pdr., 2016-12-07 20:42:11]

pdr@chromium.org changed reviewers:
+ isherman@chromium.org

[pdr., 2016-12-07 20:43:18]

On 2016/12/07 at 15:36:33, jochen wrote:
> can you reference a tracking bug from the CL description?

Good idea, done.
>
> chrome/ lgtm, but you might need to modify histograms.xml? A unit test should
fail if yes. If you end up modifying histograms.xml, please ask an OWNERS of
tools/metrics to approve that change, as I can only approve UseCounter additions
to histograms

I did need to update this after all. Done in the latest patch.



+reviewer isherman, please review the changes to histograms.xml.

[pdr., 2016-12-07 20:43:28]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 20:44:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 22:40:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 22:41:00]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2016-12-07 22:50:10]

histograms.xml lgtm

[pdr., 2016-12-07 22:55:37]

Thanks everyone!

Off we go to test.

[pdr., 2016-12-07 22:55:41]

The CQ bit was checked by pdr@chromium.org

[pdr., 2016-12-07 22:55:41]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
wangxianzhu@chromium.org, creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2551293002/#ps20001
(title: "Update histograms.xml")

[commit-bot: I haz the power, 2016-12-07 22:56:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 23:03:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481151341358630,
"parent_rev": "3693b68c0d4b4e43e78b09aad802c1bf9a12eac0", "commit_rev":
"92ab682f5f758379493d7786881850727c8481bb"}

[commit-bot: I haz the power, 2016-12-07 23:04:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-07 23:06:30]

Description was changed from

==========
Add a new flag for slimming paint invalidation

Slimming paint invalidation is a new system for paint invalidation
(see: https://goo.gl/eQczQW). It currently passes 99% of our paint
invalidation tests but is not yet mature enough to enable. This
patch adds a new flag temporarily to enable slimming paint
invalidation to test on more devices.

BUG=646176
TEST=unit_tests --gtest_filter="*AboutFlagsHistogramTest*"
==========

to

==========
Add a new flag for slimming paint invalidation

Slimming paint invalidation is a new system for paint invalidation
(see: https://goo.gl/eQczQW). It currently passes 99% of our paint
invalidation tests but is not yet mature enough to enable. This
patch adds a new flag temporarily to enable slimming paint
invalidation to test on more devices.

BUG=646176
TEST=unit_tests --gtest_filter="*AboutFlagsHistogramTest*"

Committed: https://crrev.com/8c9a7c78b3c45d14624a4bf9a1d85a60c0eb23b0
Cr-Commit-Position: refs/heads/master@{#437098}
==========

[commit-bot: I haz the power, 2016-12-07 23:06:32]

Patchset 2 (id:??) landed as
https://crrev.com/8c9a7c78b3c45d14624a4bf9a1d85a60c0eb23b0
Cr-Commit-Position: refs/heads/master@{#437098}