Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Tooltip.js

Issue 2551283002: [DevTools] Fix null tooltip errors (Closed)
Patch Set: address feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/ui/Tooltip.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Tooltip.js b/third_party/WebKit/Source/devtools/front_end/ui/Tooltip.js
index 4e41b8265d35cbd639ebad6cfb948363360ba6da..047eefef73d712fc8d93d6a3ec040f449708aeb7 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/Tooltip.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/Tooltip.js
@@ -30,12 +30,12 @@ UI.Tooltip = class {
/**
* @param {!Element} element
- * @param {!Element|string} tooltipContent
+ * @param {?Element|string} tooltipContent
* @param {string=} actionId
* @param {!Object=} options
*/
static install(element, tooltipContent, actionId, options) {
- if (typeof tooltipContent === 'string' && tooltipContent === '') {
+ if (!tooltipContent) {
delete element[UI.Tooltip._symbol];
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698