chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h - Issue 2551243002: Use ChromeLauncherControllerImpl::GetItem; cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

Issue 2551243002: Use ChromeLauncherControllerImpl::GetItem; cleanup. (Closed)

Patch Set: Add early return to ShelfModel::Set. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

index 7c733c4ec401d4e950e8c3b957dedeb4b4bf8c3d..460735c4b78f12b8ed0613ef5d10c3e30fd5c9b9 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

@@ -63,7 +63,7 @@ class ChromeLauncherControllerImpl

ash::ShelfID CreateAppLauncherItem(LauncherItemController* controller,

const std::string& app_id,

ash::ShelfItemStatus status) override;

- const ash::ShelfItem& GetItem(ash::ShelfID id) const override;

+ const ash::ShelfItem* GetItem(ash::ShelfID id) const override;

void SetItemType(ash::ShelfID id, ash::ShelfItemType type) override;

void SetItemStatus(ash::ShelfID id, ash::ShelfItemStatus status) override;

void SetItemController(ash::ShelfID id,