Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6083)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

Issue 2551243002: Use ChromeLauncherControllerImpl::GetItem; cleanup. (Closed)
Patch Set: Address comment. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
index 5315d36fb59ad61d2e9ef477f60fc131d336dbec..86735085216fcdb89c6aaa7971df872d9fa3119a 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
@@ -85,8 +85,8 @@ class ChromeLauncherController : public ash::mojom::ShelfObserver,
const std::string& app_id,
ash::ShelfItemStatus status) = 0;
- // A helper to get the shelf item with the given id, which must be valid.
- virtual const ash::ShelfItem& GetItem(ash::ShelfID id) const = 0;
+ // Returns the shelf item with the given id, or null if |id| isn't found.
+ virtual const ash::ShelfItem* GetItem(ash::ShelfID id) const = 0;
// Updates the type of an item.
virtual void SetItemType(ash::ShelfID id, ash::ShelfItemType type) = 0;

Powered by Google App Engine
This is Rietveld 408576698