DevTools: show filesystem file by default

DevTools: [Persistence] show filesystem file instead of network

Currently, as network UISourceCode gets mapped to the
filesystem UISourceCode, we still show network-based UISourceCode
in the sources panel.

However, network UISourceCodes are not really reliable: they come
and go, e.g. during reload. This results in the content blinking
unpleasantly and the undo stack being vanished. This also complicates the TabbedEditorContainer logic, which juggles tabs in a way to
match user expectations.

This patch switches to showing file-system UISourceCode.

The biggest change happens in JavaScriptSourceFrame: it now
knows about "debuggerSourceCode", which it uses to operate
breakpoints.

BUG=649837
Committed: https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15
Cr-Commit-Position: refs/heads/master@{#436837}

[lushnikov, 2016-12-05 23:50:29]

Description was changed from

==========
DevTools: show filesystem file by default

BUG=649837
==========

to

==========
DevTools: [Persistence] show filesystem file instead of network

Currently, as network UISourceCode gets mapped to the
filesystem UISourceCode, we still tend to show network-based UISourceCode
in the sources panel.

However, network UISourceCodes are not really reliable: they come
and go, e.g. during reload. This results in the content blinking
unpleasantly and the undo stack being vanished. This also complicates the
TabbedEditorContainer logic, which juggles tabs in a way to
match user expectations.

This patch switches to showing file-system UISourceCode.

The biggest change happens in JavaScriptSourceFrame: it now
knows about "debuggerSourceCode", which it uses to operate
breakpoints.

BUG=649837
==========

[lushnikov, 2016-12-05 23:50:29]

lushnikov@chromium.org changed reviewers:
+ dgozman@chromium.org

[lushnikov, 2016-12-05 23:50:40]

please, take a look

[dgozman, 2016-12-05 23:52:26]

Description was changed from

==========
DevTools: [Persistence] show filesystem file instead of network

Currently, as network UISourceCode gets mapped to the
filesystem UISourceCode, we still tend to show network-based UISourceCode
in the sources panel.

However, network UISourceCodes are not really reliable: they come
and go, e.g. during reload. This results in the content blinking
unpleasantly and the undo stack being vanished. This also complicates the
TabbedEditorContainer logic, which juggles tabs in a way to
match user expectations.

This patch switches to showing file-system UISourceCode.

The biggest change happens in JavaScriptSourceFrame: it now
knows about "debuggerSourceCode", which it uses to operate
breakpoints.

BUG=649837
==========

to

==========
DevTools: [Persistence] show filesystem file instead of network

Currently, as network UISourceCode gets mapped to the
filesystem UISourceCode, we still show network-based UISourceCode
in the sources panel.

However, network UISourceCodes are not really reliable: they come
and go, e.g. during reload. This results in the content blinking
unpleasantly and the undo stack being vanished. This also complicates the
TabbedEditorContainer logic, which juggles tabs in a way to
match user expectations.

This patch switches to showing file-system UISourceCode.

The biggest change happens in JavaScriptSourceFrame: it now
knows about "debuggerSourceCode", which it uses to operate
breakpoints.

BUG=649837
==========

[dgozman, 2016-12-06 01:14:27]

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs-expected.txt
(right):

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs-expected.txt:21:
Running: addFileMapping
Let's also test:
- open network,
- don't open filesystem;
- add a mapping.

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints-on-reload-expected.txt
(right):

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints-on-reload-expected.txt:9:
http://127.0.0.1:8000/inspector/persistence/resources/foo.js:0
Can we wait for resolve?

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-tabbed-editor-opens-network-uisourcecode-expected.txt
(right):

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-tabbed-editor-opens-network-uisourcecode-expected.txt:1:
Verify that for a fileSystem UISourceCode with network binding
TabbedEditorContainer opens network UISourceCode.
Please rename the test.

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
(right):

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js:200:
script.sourceURL + 'stub',
:sourcemap

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
(right):

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:1028:
this._breakpointAdded(/** @type {!Common.Event} */ ({data:
breakpointLocations[i]}));
Let's do this properly please.

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
(right):

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js:408: var
oldBinding = /** @type {!Persistence.PersistenceBinding} */ (event.data);
binding

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js:410: if
(oldBinding.network !== uiSourceCode && oldBinding.fileSystem !== uiSourceCode)
binding.fileSystem doesn't ever equal to uiSourceCode

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js:443:
_toPersistenceLocation(uiLocation) {
Let's inline.

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
(right):

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:264:
onBindingChanged() {
@protected

[lushnikov, 2016-12-06 02:21:05]

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs-expected.txt
(right):

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs-expected.txt:21:
Running: addFileMapping
On 2016/12/06 01:14:27, dgozman wrote:
> Let's also test:
> - open network,
> - don't open filesystem;
> - add a mapping.

Done.

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints-on-reload-expected.txt
(right):

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints-on-reload-expected.txt:9:
http://127.0.0.1:8000/inspector/persistence/resources/foo.js:0
On 2016/12/06 01:14:27, dgozman wrote:
> Can we wait for resolve?

Done.

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-tabbed-editor-opens-network-uisourcecode-expected.txt
(right):

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-tabbed-editor-opens-network-uisourcecode-expected.txt:1:
Verify that for a fileSystem UISourceCode with network binding
TabbedEditorContainer opens network UISourceCode.
On 2016/12/06 01:14:27, dgozman wrote:
> Please rename the test.

Done.

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
(right):

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js:200:
script.sourceURL + 'stub',
On 2016/12/06 01:14:27, dgozman wrote:
> :sourcemap

Done.

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
(right):

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:1028:
this._breakpointAdded(/** @type {!Common.Event} */ ({data:
breakpointLocations[i]}));
On 2016/12/06 01:14:27, dgozman wrote:
> Let's do this properly please.

Done.

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
(right):

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js:408: var
oldBinding = /** @type {!Persistence.PersistenceBinding} */ (event.data);
On 2016/12/06 01:14:27, dgozman wrote:
> binding

Done.

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js:410: if
(oldBinding.network !== uiSourceCode && oldBinding.fileSystem !== uiSourceCode)
On 2016/12/06 01:14:27, dgozman wrote:
> binding.fileSystem doesn't ever equal to uiSourceCode

Done.

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js:443:
_toPersistenceLocation(uiLocation) {
On 2016/12/06 01:14:27, dgozman wrote:
> Let's inline.

Done.

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
(right):

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:264:
onBindingChanged() {
On 2016/12/06 01:14:27, dgozman wrote:
> @protected

Done.

[lushnikov, 2016-12-06 02:29:23]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 02:30:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 06:33:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 06:33:38]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-12-06 22:01:03]

lgtm

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
(right):

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js:410: if
(oldBinding.network !== uiSourceCode && oldBinding.fileSystem !== uiSourceCode)
On 2016/12/06 02:21:05, lushnikov wrote:
> On 2016/12/06 01:14:27, dgozman wrote:
> > binding.fileSystem doesn't ever equal to uiSourceCode
> 
> Done.

Not really :-)

[lushnikov, 2016-12-06 22:14:04]

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
(right):

https://codereview.chromium.org/2551233002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js:410: if
(oldBinding.network !== uiSourceCode && oldBinding.fileSystem !== uiSourceCode)
On 2016/12/06 22:01:03, dgozman wrote:
> On 2016/12/06 02:21:05, lushnikov wrote:
> > On 2016/12/06 01:14:27, dgozman wrote:
> > > binding.fileSystem doesn't ever equal to uiSourceCode
> > 
> > Done.
> 
> Not really :-)

Now, done!

[lushnikov, 2016-12-06 22:14:08]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-12-06 22:14:08]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2551233002/#ps120001
(title: "nit")

[commit-bot: I haz the power, 2016-12-06 22:14:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 02:15:00]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1481062448145210,
"parent_rev": "0e4d4b6066a2d1e2bc493991abc2f77f55846fc4", "commit_rev":
"d565a77f05e5903efdd23f806b4b10f7b7c5fb13"}

[commit-bot: I haz the power, 2016-12-07 02:15:47]

Description was changed from

==========
DevTools: [Persistence] show filesystem file instead of network

Currently, as network UISourceCode gets mapped to the
filesystem UISourceCode, we still show network-based UISourceCode
in the sources panel.

However, network UISourceCodes are not really reliable: they come
and go, e.g. during reload. This results in the content blinking
unpleasantly and the undo stack being vanished. This also complicates the
TabbedEditorContainer logic, which juggles tabs in a way to
match user expectations.

This patch switches to showing file-system UISourceCode.

The biggest change happens in JavaScriptSourceFrame: it now
knows about "debuggerSourceCode", which it uses to operate
breakpoints.

BUG=649837
==========

to

==========
DevTools: [Persistence] show filesystem file instead of network

Currently, as network UISourceCode gets mapped to the
filesystem UISourceCode, we still show network-based UISourceCode
in the sources panel.

However, network UISourceCodes are not really reliable: they come
and go, e.g. during reload. This results in the content blinking
unpleasantly and the undo stack being vanished. This also complicates the
TabbedEditorContainer logic, which juggles tabs in a way to
match user expectations.

This patch switches to showing file-system UISourceCode.

The biggest change happens in JavaScriptSourceFrame: it now
knows about "debuggerSourceCode", which it uses to operate
breakpoints.

BUG=649837
==========

[commit-bot: I haz the power, 2016-12-07 02:15:50]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-12-07 02:19:41]

Description was changed from

==========
DevTools: [Persistence] show filesystem file instead of network

Currently, as network UISourceCode gets mapped to the
filesystem UISourceCode, we still show network-based UISourceCode
in the sources panel.

However, network UISourceCodes are not really reliable: they come
and go, e.g. during reload. This results in the content blinking
unpleasantly and the undo stack being vanished. This also complicates the
TabbedEditorContainer logic, which juggles tabs in a way to
match user expectations.

This patch switches to showing file-system UISourceCode.

The biggest change happens in JavaScriptSourceFrame: it now
knows about "debuggerSourceCode", which it uses to operate
breakpoints.

BUG=649837
==========

to

==========
DevTools: [Persistence] show filesystem file instead of network

Currently, as network UISourceCode gets mapped to the
filesystem UISourceCode, we still show network-based UISourceCode
in the sources panel.

However, network UISourceCodes are not really reliable: they come
and go, e.g. during reload. This results in the content blinking
unpleasantly and the undo stack being vanished. This also complicates the
TabbedEditorContainer logic, which juggles tabs in a way to
match user expectations.

This patch switches to showing file-system UISourceCode.

The biggest change happens in JavaScriptSourceFrame: it now
knows about "debuggerSourceCode", which it uses to operate
breakpoints.

BUG=649837

Committed: https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15
Cr-Commit-Position: refs/heads/master@{#436837}
==========

[commit-bot: I haz the power, 2016-12-07 02:19:42]

Patchset 7 (id:??) landed as
https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15
Cr-Commit-Position: refs/heads/master@{#436837}