Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 255123003: Adding myself to the wtf/OWNERS file (Closed)

Created:
6 years, 7 months ago by Mikhail
Modified:
6 years, 7 months ago
Reviewers:
Erik Corry, eseidel
CC:
blink-reviews, ojan, Mikhail, adamk+blink_chromium.org, Inactive, abarth-chromium, eseidel, Erik Corry, jochen (gone - plz use gerrit), Nico, tkent, Chris Evans
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Adding myself to the OWNERS file for WTF I've been regularily contributing to WTF for about 1 year already - basically from the Blink birth - and I'm one of the most active contributors there (around 80 commits in wtf/ folder, mostly to smart pointers and containers classes). Recent WTF contributions https://codereview.chromium.org/253753004/ MessageQueue uses Deque<OwnPtr<> > https://codereview.chromium.org/252633005/ Enable WTF::HashSet<OwnPtr<> > https://codereview.chromium.org/249363002/ Use macros instead of specializing VectorTraits explicitly https://codereview.chromium.org/240213009/ Introduce a macro enabling 'SimpleClassVectorTraits' The list of all my WTF contributions http://svnsearch.org/svnsearch/repos/BLINK/search?from=20130402&path=%2Ftrunk%2FSource%2Fwtf&author=mikhail.pozdnyakov%40intel.com Reviewing of WTF patches https://codereview.chromium.org/256743005/ Add removeAll method. https://codereview.chromium.org/228403002/ Prevent buggy use of swap and operator= on vectors https://codereview.chromium.org/223373002/ Add LinkedHashSet collection https://codereview.chromium.org/219413002/ Check for concurrent modification NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172989

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/wtf/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mikhail
PTAL The script below gives WTF commits stats for the last 3 months (if needed) ...
6 years, 7 months ago (2014-04-29 14:50:28 UTC) #1
eseidel
If Chris and Erik and other recently active owners are OK with it, lgtm.
6 years, 7 months ago (2014-04-29 16:06:33 UTC) #2
Erik Corry
LGTM, Mikhail has been doing good work on WTF.
6 years, 7 months ago (2014-04-30 07:45:54 UTC) #3
Mikhail
The CQ bit was checked by mikhail.pozdnyakov@intel.com
6 years, 7 months ago (2014-04-30 15:10:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/255123003/1
6 years, 7 months ago (2014-04-30 15:11:00 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 15:11:34 UTC) #6
Message was sent while issue was closed.
Change committed as 172989

Powered by Google App Engine
This is Rietveld 408576698