Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: third_party/WebKit/Source/modules/sensor/Sensor.h

Issue 2551223003: [Sensors] Align sensor reading updates and 'onchange' notification with rAF. (Closed)
Patch Set: rebased Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/sensor/Sensor.h
diff --git a/third_party/WebKit/Source/modules/sensor/Sensor.h b/third_party/WebKit/Source/modules/sensor/Sensor.h
index 1e2e7efb6cfa605bc131bc7ad1dd6be71b2771a8..b59979731997a6ed46f24d0be826fb5a0bf68f58 100644
--- a/third_party/WebKit/Source/modules/sensor/Sensor.h
+++ b/third_party/WebKit/Source/modules/sensor/Sensor.h
@@ -20,7 +20,6 @@ namespace blink {
class ExceptionState;
class ExecutionContext;
class SensorReading;
-class SensorUpdateNotificationStrategy;
class Sensor : public EventTargetWithInlineData,
public ActiveScriptWrappable<Sensor>,
@@ -83,11 +82,10 @@ class Sensor : public EventTargetWithInlineData,
// SensorController::Observer overrides.
void onSensorInitialized() override;
- void onSensorReadingChanged() override;
+ void onSensorReadingChanged(double timestamp) override;
void onSensorError(ExceptionCode,
const String& sanitizedMessage,
const String& unsanitizedMessage) override;
- void onSuspended() override;
void onStartRequestCompleted(bool);
void onStopRequestCompleted(bool);
@@ -95,8 +93,6 @@ class Sensor : public EventTargetWithInlineData,
void startListening();
void stopListening();
- void onSensorUpdateNotification();
-
void updateState(SensorState newState);
void reportError(ExceptionCode = UnknownError,
const String& sanitizedMessage = String(),
@@ -111,9 +107,9 @@ class Sensor : public EventTargetWithInlineData,
device::mojom::blink::SensorType m_type;
SensorState m_state;
Member<SensorProxy> m_sensorProxy;
- std::unique_ptr<SensorUpdateNotificationStrategy> m_sensorUpdateNotifier;
device::SensorReading m_storedData;
SensorConfigurationPtr m_configuration;
+ double m_lastUpdateTimestamp;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698