[Sensors] Align sensor reading updates and 'onchange' notification with rAF.

third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js

 'use strict';
 
 // Run a set of tests for a given |sensorType|. |updateReading| is
 // a called by the test to provide the mock values for sensor. |verifyReading|
 // is called so that the value read in JavaScript are the values expected (the ones
 // sent by |updateReading|).
 function runGenericSensorTests(sensorType, updateReading, verifyReading) {
   test(() => assert_throws(
     new RangeError(),
     () => new sensorType({frequency: -60})),
@@ skipping 286 matching lines @@
             }, reject);
 
             let slowSensorWrapper = new CallbackWrapper(() => {
               slowSensorNotifiedCounter++;
               if (slowSensorNotifiedCounter == 1) {
                   fastSensor.start();
               } else if (slowSensorNotifiedCounter == 2) {
                 // By the moment slow sensor (9 Hz) is notified for the
                 // next time, the fast sensor (30 Hz) has been notified
                 // for int(30/9) = 3 times.
-                assert_equals(fastSensorNotifiedCounter, 3);
+                // In actual implementation updates are bound to rAF,
+                // (not to a timer) sometimes fast sensor gets invoked 4 times.
+                assert_true(fastSensorNotifiedCounter == 3 ||
+                            fastSensorNotifiedCounter == 4);

[foolip, 2016/12/19 13:23:47]

Shouldn't this change have caused the number of update events to decrease only?

A useful test for this change would be a 100 Hz sensor, and verifying that at
most one event is fired per animation frame, if that's the intended behavior.

                 fastSensor.stop();
                 slowSensor.stop();
                 resolve(mockSensor);
               }
             }, reject);
 
             fastSensor.onchange = fastSensorWrapper.callback;
             slowSensor.onchange = slowSensorWrapper.callback;
             fastSensor.onerror = reject;
             slowSensor.onerror = reject;
           });
         })
         .then(mockSensor => { return mockSensor.removeConfigurationCalled(); });
 
     return testPromise;
   }
 
   sensor_test(sensor => {
     return checkFrequencyHintWorks(sensor);
   }, 'Test that frequency hint works (onchange reporting).');
 
   sensor_test(sensor => {
     sensor.mockSensorProvider.setContinuousReportingMode();
     return checkFrequencyHintWorks(sensor);
   }, 'Test that frequency hint works (continuous reporting).');
 }