third_party/WebKit/Source/core/BUILD.gn - Issue 2551213002: Revert of Disable Precompile-platform with clang-cl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/BUILD.gn

Issue 2551213002: Revert of Disable Precompile-platform with clang-cl. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/BUILD.gn

diff --git a/third_party/WebKit/Source/core/BUILD.gn b/third_party/WebKit/Source/core/BUILD.gn

index 59bbee0defdc5ca8aa556137c48edda9ce55273f..0c58627a1145a40ced541856118442d19135c7d8 100644

--- a/third_party/WebKit/Source/core/BUILD.gn

+++ b/third_party/WebKit/Source/core/BUILD.gn

@@ -52,8 +52,7 @@

config("blink_core_pch") {

if (enable_precompiled_headers) {

- # TODO(thakis): Enable for clang once it works, https://crbug.com/667891

- if (is_win && !is_clang) {

+ if (is_win) {

# This is a string rather than a file GN knows about. It has to match

# exactly what's in the /FI flag below, and what might appear in the

# source code in quotes for an #include directive.

« no previous file with comments | « no previous file | no next file » | no next file with comments »