Chromium Code Reviews
DescriptionRevert of Disable Precompile-platform with clang-cl. (patchset #1 id:1 of https://codereview.chromium.org/2533853003/ )
Reason for revert:
This should work after yesterday's clang roll. We now have a bot that builds with symbols, and I was able to build blink_tests with symbols locally with this reverted locally.
Original issue's description:
> Reland of Disable Precompile-platform with clang-cl. (patchset #1 id:1 of https://codereview.chromium.org/2526383002/ )
>
> Reason for revert:
> Clang still asserts when building Precompile-core.obj, but it's somewhere else:
> Assertion failed: AllowUnresolvedNodes && "Cannot handle unresolved nodes"...
>
> Original issue's description:
> > Revert of Disable Precompile-platform with clang-cl. (patchset #1 id:1 of https://codereview.chromium.org/2520833005/ )
> >
> > Reason for revert:
> > The crash is now hopefully fixed in clang-cl.
> >
> > Original issue's description:
> > > Disable Precompile-platform with clang-cl.
> > >
> > > It currently asserts while trying to build that PCH file.
> > >
> > > BUG=667891, 495697
> > > NOTRY=true
> > >
> > > Committed: https://crrev.com/5b7b04e7fa59d53b8b7917d4c0cf4081abdfb0e3
> > > Cr-Commit-Position: refs/heads/master@{#434028}
> >
> > TBR=rnk@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=667891, 495697
> >
> > Committed: https://crrev.com/a0eb8ed36a1c3e2c5becc95ef03d42655c7cd95c
> > Cr-Commit-Position: refs/heads/master@{#434534}
>
> TBR=thakis@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=667891, 495697
>
> Committed: https://crrev.com/c43462be8948e6a3a1c9a7d6bc6b10fc5fc789b8
> Cr-Commit-Position: refs/heads/master@{#434737}
TBR=rnk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=667891, 495697
Committed: https://crrev.com/171edcc0653bf8abfea519465208fc92998a54ce
Cr-Commit-Position: refs/heads/master@{#436458}
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|
|||||||||||||||||||