Issue 25512004: Fixed Keyboard overlay overridden keys alignment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25512004: Fixed Keyboard overlay overridden keys alignment (Closed)

Created:
7 years, 2 months ago by François Beaufort

Modified:
7 years, 2 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fixed Keyboard overlay overridden keys alignment Remap the <Search> key to <Escape> in chrome://settings/keyboard-overlay and acknowledge that the <Search> key proudly shows the "Esc" aligned to the left. BUG=302912 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226521

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/resources/chromeos/keyboard_overlay.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/beaufort.francois@gmail.com/25512004/1

7 years, 2 months ago (2013-10-02 16:32:37 UTC) #4

Message was sent while issue was closed.

Change committed as 226521

Expand Messages | Collapse Messages